Skip to content

[WIP] Update restrictions of the private endpoint of Starter#21872

Open
sunxiaoguang wants to merge 5 commits intopingcap:release-8.5from
sunxiaoguang:private_endpoint
Open

[WIP] Update restrictions of the private endpoint of Starter#21872
sunxiaoguang wants to merge 5 commits intopingcap:release-8.5from
sunxiaoguang:private_endpoint

Conversation

@sunxiaoguang
Copy link
Copy Markdown
Contributor

@sunxiaoguang sunxiaoguang commented Oct 7, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sunxiaoguang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for TiDB Cloud Starter to include an important restriction regarding private endpoints. The change clarifies that a private endpoint is shared across all clusters within the same region, providing users with a more complete understanding of the service's behavior and limitations.

Highlights

  • Private Endpoint Restrictions: Added a new restriction to the documentation clarifying that private endpoints are shared among all clusters within the same region for TiDB Cloud Starter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a restriction note about shared private endpoints for Starter clusters. My review includes a suggestion to improve the clarity and consistency of the new text, ensuring it aligns with the terminology used elsewhere in the document.

Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@qiancai qiancai self-assigned this Oct 9, 2025
@qiancai qiancai added area/tidb-cloud This PR relates to the area of TiDB Cloud. translation/no-need No need to translate this PR. labels Oct 9, 2025
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 9, 2025
@sunxiaoguang sunxiaoguang changed the title Update restrictions of the private endpoint of Starter [WIP] Update restrictions of the private endpoint of Starter Oct 9, 2025
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025
@sunxiaoguang sunxiaoguang changed the title [WIP] Update restrictions of the private endpoint of Starter Update restrictions of the private endpoint of Starter Dec 20, 2025
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2025
@lilin90 lilin90 self-requested a review February 4, 2026 02:43
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 4, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Feb 4, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-04 02:48:10.311490863 +0000 UTC m=+235161.412889583: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Feb 4, 2026
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Feb 4, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Feb 4, 2026
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2026
@lilin90 lilin90 requested a review from likidu February 4, 2026 02:53
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@sunxiaoguang sunxiaoguang changed the title Update restrictions of the private endpoint of Starter [WIP] Update restrictions of the private endpoint of Starter Feb 4, 2026
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants