tidb: fix tiup cdc cli changefeed create command by adding --config=./changefeed.toml#22857
Conversation
hfxsd
added
needs-cherry-pick-release-8.5
ti-chi-bot
Bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a placeholder file named temp.md. Feedback indicates that this file should be removed as it does not contain the documentation changes described in the pull request title, and the author should instead provide the actual updates to the relevant documentation files.
I am having trouble creating individual review comments. Click here to see my feedback.
temp.md (1)
This file appears to be a placeholder and does not contain the documentation changes described in the pull request title. Please remove this file and submit the actual updates to the relevant documentation (for example, adding --config=./changefeed.toml to the tiup cdc cli changefeed create command examples in ticdc/ticdc-manage-changefeed.md).
References
- Documentation should be complete and align with the technical changes described in the PR. (link)
Synced from: pingcap/docs-cn#21609 Target PR: pingcap#22857 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Auto-sync completed successfully Source PR: pingcap/docs-cn#21609 English documentation has been updated based on Chinese documentation changes. |
github-actions
Bot
force-pushed
the
fix-command-tiup-cdc-cli-changefeed-create--21609
branch
from
26e5afe to
9812243
Compare
There was a problem hiding this comment.
Code Review
This pull request adds a placeholder file temp.md containing only test text. Feedback indicates that this file should be removed and replaced with the actual documentation updates for the tiup cdc cli changefeed create command as intended by the pull request.
I am having trouble creating individual review comments. Click here to see my feedback.
temp.md (1)
This file appears to be a placeholder. The pull request title indicates a fix for the tiup cdc cli changefeed create command, but the actual documentation changes are missing. Please remove this temporary file and include the intended updates in the appropriate documentation files.
References
- Documentation should be complete, clear, and technically accurate (Style Guide Line 14). (link)
|
@wk989898: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
tiup cdc cli changefeed createcommand by adding--config=./changefeed.tomldocs-cn#21609Do your changes match any of the following descriptions?