premium: remove tidb-cloud-log-redaction.md#22895
Conversation
ti-chi-bot
Bot
added
the
missing-translation-status
ti-chi-bot
Bot
added
the
size/XS
hfxsd
added
translation/no-need
|
@xboxeer: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the 'User Log Redaction' entry from the TiDB Cloud Premium Table of Contents. Feedback highlights that removing this link without deleting the underlying markdown file results in an orphaned file and may make documentation for a supported feature inaccessible to users. It is recommended to clarify the intent or delete the file if the feature is no longer supported.
| - [TiDB CloudへのTLS接続](/tidb-cloud/premium/tidb-cloud-tls-connect-to-premium.md) | ||
| - データアクセス制御 | ||
| - [二重層データ暗号化](/tidb-cloud/premium/dual-layer-data-encryption-premium.md) | ||
| - [ユーザーによるログの編集](/tidb-cloud/tidb-cloud-log-redaction.md) |
There was a problem hiding this comment.
The PR title indicates that the file tidb-cloud-log-redaction.md is being removed, but the current changes only remove its entry from the TOC. This results in an orphaned file in the repository. If the file is no longer needed, it should be deleted from the repository as well. However, note that the file content itself explicitly states that the feature is supported for TiDB Cloud Premium instances. If the feature is still supported, removing this link from the TOC will make the documentation inaccessible to Premium users. Please clarify the intent.
References
- The documentation should be complete and accurate. Removing a link to a supported feature's documentation without deleting the file or updating its content to reflect deprecation leads to an incomplete user experience. (link)
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?