Skip to content

planner: add the doc for the SEMI_JOIN_REWRITE hint#9734

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
TomShawn:semi-join-rewrite-hint
Aug 5, 2022
Merged

planner: add the doc for the SEMI_JOIN_REWRITE hint#9734
ti-chi-bot merged 3 commits into
pingcap:masterfrom
TomShawn:semi-join-rewrite-hint

Conversation

@TomShawn

@TomShawn TomShawn commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

planner: add the doc for the SEMI_JOIN_REWRITE hint

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 July 27, 2022 07:19
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2022
@TomShawn TomShawn requested review from Oreoxmt and winoros and removed request for shichun-0415 July 27, 2022 07:20
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.2 This PR/issue applies to TiDB v6.2. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR's assignee is translating this PR. labels Jul 27, 2022
Oreoxmt
Oreoxmt approved these changes Aug 4, 2022
View reviewed changes

@Oreoxmt Oreoxmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread optimizer-hints.md Outdated
Comment thread optimizer-hints.md Outdated
Comment thread optimizer-hints.md Outdated
Comment thread subquery-optimization.md Outdated
Comment thread subquery-optimization.md Outdated
Comment thread optimizer-hints.md Outdated
Comment thread optimizer-hints.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
@TomShawn

TomShawn commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot

ti-chi-bot commented Aug 5, 2022

Copy link
Copy Markdown
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 5, 2022
@TomShawn

TomShawn commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot

ti-chi-bot commented Aug 5, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c343758

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 5, 2022
@TomShawn

TomShawn commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot

ti-chi-bot commented Aug 5, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 63c048d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@TomShawn

TomShawn commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

/rebase

@TomShawn TomShawn force-pushed the semi-join-rewrite-hint branch from 63c048d to 6895032 Compare August 5, 2022 05:59
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@TomShawn

TomShawn commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot

ti-chi-bot commented Aug 5, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 38f1798

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit 93c7c3a into pingcap:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros Awaiting requested review from winoros
1 more reviewer
@Oreoxmt Oreoxmt Oreoxmt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.2 This PR/issue applies to TiDB v6.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomShawn @ti-chi-bot @Oreoxmt