change failure to thiserror#354
Open
mapleFU wants to merge 5 commits into
Open
Conversation
Signed-off-by: mapleFU <1506118561@qq.com>
Signed-off-by: mapleFU <1506118561@qq.com>
Signed-off-by: mapleFU <1506118561@qq.com>
Signed-off-by: mapleFU <1506118561@qq.com>
Signed-off-by: mapleFU <1506118561@qq.com>
Contributor
|
We might need to add this related issue in the description: #343 |
ziyi-yan
reviewed
Jun 19, 2020
| [`failure`]: https://docs.rs/failure/0.1.5/failure/ | ||
| [`thiserror`]: https://docs.rs/thiserror/1.0.18/thiserror/ | ||
|
|
||
| The [failure guide][fg] describes [several] error handling patterns. |
Contributor
There was a problem hiding this comment.
This failure guide might be removed or replaced with other materials based on thiserror crate.
Author
There was a problem hiding this comment.
Well, I asked brain anderson about this, but he didn't reply yet. This part shows patterns for using error handling, I think replace it maybe not good.
Would you mind give some suggestion here?
Author
There was a problem hiding this comment.
Maybe I can add strikethrough on contents about thiserror @ziyi-yan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
failurecrate is deprecated now, I changed it tothiserror.What is changed and how it works?
Check List
Tests
Side effects
None.
Related changes
None