From 2a32da5d21a79fc4b442540835bf281fadf51de2 Mon Sep 17 00:00:00 2001 From: shirly Date: Mon, 22 Jun 2020 18:15:32 +0800 Subject: [PATCH 1/2] fix clippy Signed-off-by: shirly --- courses/dss/linearizability/src/models.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/courses/dss/linearizability/src/models.rs b/courses/dss/linearizability/src/models.rs index 0ab863607..8afefafcb 100644 --- a/courses/dss/linearizability/src/models.rs +++ b/courses/dss/linearizability/src/models.rs @@ -35,7 +35,7 @@ impl Model for KvModel { ) -> Vec> { let mut map = HashMap::new(); for op in history { - let v = map.entry(op.input.key.clone()).or_insert_with(|| vec![]); + let v = map.entry(op.input.key.clone()).or_insert(vec![]); (*v).push(op); } let mut ret = vec![]; @@ -56,11 +56,11 @@ impl Model for KvModel { EventKind::CallEvent => { let key = event.value.input().key.clone(); matched.insert(event.id, key.clone()); - m.entry(key).or_insert_with(|| vec![]).push(event); + m.entry(key).or_insert(vec![]).push(event); } EventKind::ReturnEvent => { let key = matched[&event.id].clone(); - m.entry(key).or_insert_with(|| vec![]).push(event); + m.entry(key).or_insert(vec![]).push(event); } } } From 1b728eeedb0deb087d47d77be44248f27331aa2c Mon Sep 17 00:00:00 2001 From: shirly Date: Tue, 23 Jun 2020 10:08:37 +0800 Subject: [PATCH 2/2] fix clippy Signed-off-by: shirly --- courses/dss/linearizability/src/models.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/courses/dss/linearizability/src/models.rs b/courses/dss/linearizability/src/models.rs index 8afefafcb..3dd93136d 100644 --- a/courses/dss/linearizability/src/models.rs +++ b/courses/dss/linearizability/src/models.rs @@ -35,7 +35,7 @@ impl Model for KvModel { ) -> Vec> { let mut map = HashMap::new(); for op in history { - let v = map.entry(op.input.key.clone()).or_insert(vec![]); + let v = map.entry(op.input.key.clone()).or_insert_with(Vec::default); (*v).push(op); } let mut ret = vec![]; @@ -56,11 +56,11 @@ impl Model for KvModel { EventKind::CallEvent => { let key = event.value.input().key.clone(); matched.insert(event.id, key.clone()); - m.entry(key).or_insert(vec![]).push(event); + m.entry(key).or_insert_with(Vec::default).push(event); } EventKind::ReturnEvent => { let key = matched[&event.id].clone(); - m.entry(key).or_insert(vec![]).push(event); + m.entry(key).or_insert_with(Vec::default).push(event); } } }