fix(pd): wrong image can be fixed after pdgroup is created (#6536)

Author: liubog2008

cmd/runtime-gen/generators/runtime.go

@@ -505,6 +505,14 @@ func (g *$.|pub$) TemplateAnnotations() map[string]string {
 	return g.Spec.Template.Annotations
 }
 
+func (g *$.|pub$) SetTemplateLabels(ls map[string]string) {
+	g.Spec.Template.Labels = ls
+}
+
+func (g *$.|pub$) SetTemplateAnnotations(anno map[string]string) {
+	g.Spec.Template.Annotations = anno
+}
+
 func (g *$.|pub$) Features() []metav1alpha1.Feature {
 	return g.Spec.Features
 }

pkg/apiutil/core/v1alpha1/group.go

@@ -188,3 +188,23 @@ func SetStatusSelector[
 
 	return changed
 }
+
+func TemplateAnnotations[
+	S scope.Group[F, T],
+	F client.Object,
+	T runtime.Group,
+](f F) map[string]string {
+	obj := scope.From[S](f)
+
+	return obj.TemplateAnnotations()
+}
+
+func SetTemplateAnnotations[
+	S scope.Group[F, T],
+	F client.Object,
+	T runtime.Group,
+](f F, anno map[string]string) {
+	obj := scope.From[S](f)
+
+	obj.SetTemplateAnnotations(anno)
+}

pkg/controllers/pd/builder.go

@@ -62,10 +62,6 @@ func (r *Reconciler) NewRunner(state *tasks.ReconcileContext, reporter task.Task
 		tasks.TaskConfigMap(state, r.Client),
 		common.TaskPVC[scope.PD](state, r.Client, r.VolumeModifierFactory, tasks.PVCNewer()),
 		tasks.TaskPod(state, r.Client),
-		// If pd client has not been registered yet, do not update status of the pd
-		task.IfBreak(tasks.CondPDClientIsNotRegisterred(state),
-			tasks.TaskStatusUnknown(),
-		),
 		common.TaskInstanceConditionSynced[scope.PD](state),
 		common.TaskInstanceConditionReady[scope.PD](state),
 		common.TaskInstanceConditionRunning[scope.PD](state),

pkg/controllers/pd/tasks/status.go

@@ -29,12 +29,6 @@ import (
 	"github.com/pingcap/tidb-operator/pkg/utils/task/v3"
 )
 
-func TaskStatusUnknown() task.Task {
-	return task.NameTaskFunc("StatusUnknown", func(_ context.Context) task.Result {
-		return task.Wait().With("status of the pd is unknown")
-	})
-}
-
 //nolint:gocyclo // refactor if possible
 func TaskStatus(state *ReconcileContext, c client.Client) task.Task {
 	return task.NameTaskFunc("Status", func(ctx context.Context) task.Result {

pkg/runtime/group.go

@@ -37,6 +37,9 @@ type Group interface {
 	TemplateLabels() map[string]string
 	TemplateAnnotations() map[string]string
 
+	SetTemplateLabels(map[string]string)
+	SetTemplateAnnotations(map[string]string)
+
 	SetTemplateClusterTLS(ca, certKeyPair string)
 
 	MinReadySeconds() int64