fix(updater): ignore deleting instances in topology policy (#6538)

Author: liubog2008

cmd/runtime-gen/generators/runtime.go

@@ -586,6 +586,10 @@ func (g *$.|pub$) MinReadySeconds() int64 {
 	}
 	return *g.Spec.MinReadySeconds
 }
+
+func (g *$.|pub$) SchedulePolicies() []v1alpha1.SchedulePolicy {
+	return g.Spec.SchedulePolicies
+}
 `, t)
 
 	return sw.Error()

pkg/apiutil/core/v1alpha1/group.go

@@ -67,6 +67,14 @@ func MinReadySeconds[
 	return scope.From[S](f).MinReadySeconds()
 }
 
+func SchedulePolicies[
+	S scope.Group[F, T],
+	F client.Object,
+	T runtime.Group,
+](f F) []v1alpha1.SchedulePolicy {
+	return scope.From[S](f).SchedulePolicies()
+}
+
 // IsGroupHealthyAndUpToDate is defined to check whether all replicas of the group are healthy and up to date
 // TODO: simplify it by a condition
 func IsGroupHealthyAndUpToDate[

pkg/apiutil/core/v1alpha1/instance.go

@@ -18,6 +18,7 @@ import (
 	"time"
 
 	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
 	"github.com/pingcap/tidb-operator/api/v2/core/v1alpha1"
@@ -29,6 +30,14 @@ import (
 	maputil "github.com/pingcap/tidb-operator/pkg/utils/map"
 )
 
+func Topology[
+	S scope.Instance[F, T],
+	F client.Object,
+	T runtime.Instance,
+](f F) v1alpha1.Topology {
+	return scope.From[S](f).GetTopology()
+}
+
 func IsReady[
 	S scope.Instance[F, T],
 	F client.Object,
@@ -335,3 +344,25 @@ func WithLegacyK8sAppLabels() PVCPatch {
 		))
 	})
 }
+
+// IsDeleting check whether an instance is deleting
+// TODO: change to use scope
+func IsDeleting(instance runtime.Instance) bool {
+	if !instance.GetDeletionTimestamp().IsZero() {
+		return true
+	}
+
+	if _, ok := instance.GetAnnotations()[v1alpha1.AnnoKeyDeferDelete]; ok {
+		return true
+	}
+
+	if instance.IsOffline() {
+		return true
+	}
+
+	if meta.IsStatusConditionTrue(instance.Conditions(), v1alpha1.StoreOfflinedConditionType) {
+		return true
+	}
+
+	return false
+}

pkg/runtime/group.go

@@ -14,7 +14,11 @@
 
 package runtime
 
-import "sigs.k8s.io/controller-runtime/pkg/client"
+import (
+	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"github.com/pingcap/tidb-operator/api/v2/core/v1alpha1"
+)
 
 type Group interface {
 	Object
@@ -43,6 +47,8 @@ type Group interface {
 	SetTemplateClusterTLS(ca, certKeyPair string)
 
 	MinReadySeconds() int64
+
+	SchedulePolicies() []v1alpha1.SchedulePolicy
 }
 
 type GroupT[T GroupSet] interface {