Skip to content

Commit 50d95cd

Browse files
authored
test(e2e): retry twice and enable PDReadyAPI (#6496)
1 parent 00b1d7c commit 50d95cd

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

cmd/testing-workload/pd_region.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const (
3838
defaultGRPCKeepAliveTimeout = 3 * time.Second
3939
defaultPDServerTimeout = 3 * time.Second
4040

41-
defaultLeaderTransferTime = 200 * time.Millisecond
41+
defaultLeaderTransferTime = 100 * time.Millisecond
4242
)
4343

4444
func NewPDClient(pdAddrs []string) (pd.Client, error) {
@@ -129,9 +129,9 @@ func PDRegionAccess(ctx context.Context) error {
129129
func accessPDAPI(ctx context.Context, client pd.Client) error {
130130
// retry once
131131
var lastErr error
132-
for range 2 {
132+
for range 3 {
133133
if lastErr != nil {
134-
fmt.Println("retry because of ", lastErr)
134+
fmt.Printf("[%s] retry because of %v\n", time.Now().String(), lastErr)
135135
}
136136

137137
_, _, err1 := client.GetTS(ctx)
@@ -146,13 +146,13 @@ func accessPDAPI(ctx context.Context, client pd.Client) error {
146146
}
147147

148148
if err1 != nil {
149-
lastErr = err1
149+
lastErr = fmt.Errorf("get ts failed: %w", err1)
150150
if !strings.Contains(err1.Error(), "not leader") {
151151
break
152152
}
153153
}
154154
if err2 != nil {
155-
lastErr = err2
155+
lastErr = fmt.Errorf("scan region failed: %w", err2)
156156
// only retry for not leader err
157157
if !strings.Contains(err2.Error(), "not leader") {
158158
break

tests/e2e/suite/availability/pd.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ var _ = ginkgo.Describe("PD Availability Test", label.PD, label.KindAvail, label
4444
})
4545
})
4646

47-
ginkgo.Context("NextGen PDMS", label.KindNextGen, label.P0, label.Features(metav1alpha1.UseTSOReadyAPI), func() {
47+
ginkgo.Context("NextGen PDMS", label.KindNextGen, label.P0, label.Features(metav1alpha1.UseTSOReadyAPI, metav1alpha1.UsePDReadyAPI), func() {
4848
workload := f.SetupWorkload()
49-
f.SetupCluster(data.WithFeatureGates(metav1alpha1.UseTSOReadyAPI))
49+
f.SetupCluster(data.WithFeatureGates(metav1alpha1.UseTSOReadyAPI, metav1alpha1.UsePDReadyAPI))
5050
// TODO: wait until the pr is merged
5151
ginkgo.It("No error when rolling update pd in next-gen", label.KindNextGen, func(ctx context.Context) {
5252
f.MustCreateS3(ctx)

0 commit comments

Comments
 (0)