Skip to content

Commit a8e8f3c

Browse files
committed
refactor: remove requestRateLimit from copIteratorWorker and use req.CoprRequestRateLimit directly
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
1 parent 3905eea commit a8e8f3c

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

pkg/store/copr/coprocessor.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1038,13 +1038,8 @@ type copIteratorWorker struct {
10381038
req *kv.Request
10391039
respChan chan<- *copResponse
10401040
finishCh <-chan struct{}
1041-
// requestRateLimit controls the aggregate number of in-flight cop requests.
1042-
// The token lifecycle is tied to request send/response receive instead of result consumption.
1043-
// Today this field carries only request-local limiters. Query-scoped
1044-
// per-store limiters are resolved per task after the target store is known.
1045-
requestRateLimit kv.CoprRequestLimiter
1046-
vars *tikv.Variables
1047-
kvclient *txnsnapshot.ClientHelper
1041+
vars *tikv.Variables
1042+
kvclient *txnsnapshot.ClientHelper
10481043

10491044
memTracker *memory.Tracker
10501045

@@ -1244,7 +1239,6 @@ func newCopIteratorWorker(it *copIterator, taskCh <-chan *copTask) *copIteratorW
12441239
req: it.req,
12451240
respChan: it.respChan,
12461241
finishCh: it.finishCh,
1247-
requestRateLimit: it.req.CoprRequestRateLimit,
12481242
vars: it.vars,
12491243
kvclient: txnsnapshot.NewClientHelper(it.store.store, &it.resolvedLocks, &it.committedLocks, false),
12501244
memTracker: it.memTracker,
@@ -1820,7 +1814,7 @@ func (worker *copIteratorWorker) handleTaskOnce(bo *Backoffer, task *copTask) (*
18201814
if exit {
18211815
return nil, nil
18221816
}
1823-
releaseRequestRateLimit, exit := acquireCoprRequestLimiter(worker.requestRateLimit, worker.finishCh)
1817+
releaseRequestRateLimit, exit := acquireCoprRequestLimiter(worker.req.CoprRequestRateLimit, worker.finishCh)
18241818
if exit {
18251819
if releaseQueryCopStoreLimiter != nil {
18261820
releaseQueryCopStoreLimiter()

0 commit comments

Comments
 (0)