docs: replace deprecated PingCAP domains#67522
Conversation
|
Review Complete Findings: 0 issues ℹ️ Learn more details on Pantheon AI. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @wuhuizuo. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughDomain migration of download URLs for PingCAP nightly components across scripts and docs: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dumpling/README.md`:
- Around line 32-34: Update the download URL for `bin/sync_diff_inspector` in
the README so it uses HTTPS instead of HTTP: replace
`http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
with
`https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
to match the other entries (`bin/tidb-server`, `bin/tidb-lightning`) and avoid
the HTTP->HTTPS redirect.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 20910d86-9f5e-43c5-a765-0ae2c7c51abf
📒 Files selected for processing (3)
br/tests/download_tools.shdumpling/README.mddumpling/install.sh
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #67522 +/- ##
================================================
+ Coverage 77.7474% 78.7924% +1.0449%
================================================
Files 1959 1960 +1
Lines 543377 543542 +165
================================================
+ Hits 422462 428270 +5808
+ Misses 120074 114247 -5827
- Partials 841 1025 +184
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@wuhuizuo: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ? |
|
@wuhuizuo: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test check-dev2 |
|
/retest |
|
@wuhuizuo: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@wuhuizuo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #67527
Problem Summary:
download.pingcap.orgis being deprecated in favor ofdownload.pingcap.com, but TiDB still has old-domain references in Dumpling install/docs and BR test download helpers onmaster.What changed and how does it work?
download.pingcap.orgreferences withdownload.pingcap.cominbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shmasterbehavior unchangedCheck List
Tests
Manual test steps:
git diff --checkbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shcurl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-master-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz#67527is labeledtype/compatibilitySide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.