docs: replace deprecated PingCAP domains#67524
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @wuhuizuo. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughUpdated download hosts from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dumpling/install.sh`:
- Around line 8-12: The script uses an undefined variable ARCH_SUFFIX in the
wget URL and still hardcodes linux-amd64 for extraction, causing failures on
non-amd64 runs; fix by defining ARCH_SUFFIX near the top (e.g., default
ARCH_SUFFIX=${ARCH_SUFFIX:-amd64} or derive from uname -m) and replace the
hardcoded linux-amd64 in both the download URL and the tar extraction command to
use $ARCH_SUFFIX, ensuring TOOLS_TAG remains used as before; alternatively, if
multi-arch support is not intended, remove ARCH_SUFFIX from the wget URL and
make both download and extraction consistently use linux-amd64.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 8248691a-a005-428a-a987-e54078de6bd2
📒 Files selected for processing (3)
br/tests/download_tools.shdumpling/README.mddumpling/install.sh
| <<<<<<< HEAD | ||
| wget http://download.pingcap.com/tidb-toolkit-$TOOLS_TAG-linux-amd64.tar.gz -O tools.tar.gz | ||
| ======= | ||
| wget http://download.pingcap.com/tidb-toolkit-$TOOLS_TAG-linux-$ARCH_SUFFIX.tar.gz -O tools.tar.gz | ||
| >>>>>>> 2caf3752b (docs: replace deprecated PingCAP domains) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether the arch-specific variant is fully wired through.
rg -n 'ARCH_SUFFIX|linux-amd64' dumpling/install.sh
rg -n 'run:\s*sh dumpling/install\.sh' .github/workflows/integration-test-dumpling.ymlRepository: pingcap/tidb
Length of output: 492
Ensure ARCH_SUFFIX is properly defined if using the architecture-parameterized download path.
The download uses $ARCH_SUFFIX but the variable is undefined in the script, and line 14 still hardcodes linux-amd64 for extraction. The workflow also runs the script without setting this variable, causing extraction to fail on non-amd64 architectures. Either define ARCH_SUFFIX at the script start and update both the download and extraction paths to use it, or keep both paths hardcoded as linux-amd64.
🧰 Tools
🪛 GitHub Actions: Dumpling
[error] 8-8: Shell script failed with syntax error: "redirection unexpected". Process completed with exit code 2.
🪛 Shellcheck (0.11.0)
[error] 8-8: Couldn't parse this here string. Fix to allow more checks.
(SC1073)
[info] 8-8: The mentioned syntax error was in this simple command.
(SC1009)
[error] 8-8: Fix any mentioned problems and try again.
(SC1072)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@dumpling/install.sh` around lines 8 - 12, The script uses an undefined
variable ARCH_SUFFIX in the wget URL and still hardcodes linux-amd64 for
extraction, causing failures on non-amd64 runs; fix by defining ARCH_SUFFIX near
the top (e.g., default ARCH_SUFFIX=${ARCH_SUFFIX:-amd64} or derive from uname
-m) and replace the hardcoded linux-amd64 in both the download URL and the tar
extraction command to use $ARCH_SUFFIX, ensuring TOOLS_TAG remains used as
before; alternatively, if multi-arch support is not intended, remove ARCH_SUFFIX
from the wget URL and make both download and extraction consistently use
linux-amd64.
|
@wuhuizuo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #67527
Problem Summary:
download.pingcap.orgis being deprecated in favor ofdownload.pingcap.com, and release-8.1 still has old-domain references in Dumpling install/docs and BR test download helpers.What changed and how does it work?
masterto release-8.1download.pingcap.orgreferences withdownload.pingcap.cominbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shCheck List
Tests
Manual test steps:
git diff --checkbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shcurl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gzSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.