Skip to content

docs: replace deprecated PingCAP domains#67524

Open
wuhuizuo wants to merge 2 commits into
release-8.1from
fix/update-pingcap-domains-release-8-1
Open

docs: replace deprecated PingCAP domains#67524
wuhuizuo wants to merge 2 commits into
release-8.1from
fix/update-pingcap-domains-release-8-1

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 2, 2026

What problem does this PR solve?

Issue Number: ref #67527

Problem Summary:

download.pingcap.org is being deprecated in favor of download.pingcap.com, and release-8.1 still has old-domain references in Dumpling install/docs and BR test download helpers.

What changed and how does it work?

  • backport the domain migration from master to release-8.1
  • replace deprecated download.pingcap.org references with download.pingcap.com in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • preserve the existing release-8.1-specific script behavior while only changing the download host

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test steps:

  • git diff --check
  • verify no remaining old-domain references in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • curl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

none

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leavrth, okjiang for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. component/dumpling This is related to Dumpling of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 2, 2026

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

Updated download hosts from download.pingcap.org to download.pingcap.com in three scripts/docs that fetch nightly or toolkit artifacts; no other logic or control flow changes present.

Changes

Cohort / File(s) Summary
BR test script
br/tests/download_tools.sh
Replaced https://download.pingcap.org/... URLs with https://download.pingcap.com/... for nightly artifacts (tiflash, tidb, ticdc).
Dumpling docs
dumpling/README.md
Replaced download.pingcap.org with download.pingcap.com for tiDB/enterprise tools/tidb-lightning download links in test/setup instructions.
Dumpling install script
dumpling/install.sh
Changed toolkit download host from http://download.pingcap.org/ to http://download.pingcap.com/; extraction and installation steps unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

"I hopped through URLs, quick and spry,
From .org to .com beneath the sky,
Three little links, a tiny cheer,
Tools arrive—no bugs appear! 🐇✨"

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: replace deprecated PingCAP domains' accurately summarizes the main change—updating download URLs from download.pingcap.org to download.pingcap.com across three files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description comprehensively follows the required template with all essential sections completed: issue reference, clear problem statement, detailed changelog, testing approach with manual test steps, and release notes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-pingcap-domains-release-8-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dumpling/install.sh`:
- Around line 8-12: The script uses an undefined variable ARCH_SUFFIX in the
wget URL and still hardcodes linux-amd64 for extraction, causing failures on
non-amd64 runs; fix by defining ARCH_SUFFIX near the top (e.g., default
ARCH_SUFFIX=${ARCH_SUFFIX:-amd64} or derive from uname -m) and replace the
hardcoded linux-amd64 in both the download URL and the tar extraction command to
use $ARCH_SUFFIX, ensuring TOOLS_TAG remains used as before; alternatively, if
multi-arch support is not intended, remove ARCH_SUFFIX from the wget URL and
make both download and extraction consistently use linux-amd64.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8248691a-a005-428a-a987-e54078de6bd2

📥 Commits

Reviewing files that changed from the base of the PR and between 0987792 and 20d09f7.

📒 Files selected for processing (3)
  • br/tests/download_tools.sh
  • dumpling/README.md
  • dumpling/install.sh

Comment thread dumpling/install.sh Outdated
Comment on lines +8 to +12
<<<<<<< HEAD
wget http://download.pingcap.com/tidb-toolkit-$TOOLS_TAG-linux-amd64.tar.gz -O tools.tar.gz
=======
wget http://download.pingcap.com/tidb-toolkit-$TOOLS_TAG-linux-$ARCH_SUFFIX.tar.gz -O tools.tar.gz
>>>>>>> 2caf3752b (docs: replace deprecated PingCAP domains)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether the arch-specific variant is fully wired through.
rg -n 'ARCH_SUFFIX|linux-amd64' dumpling/install.sh
rg -n 'run:\s*sh dumpling/install\.sh' .github/workflows/integration-test-dumpling.yml

Repository: pingcap/tidb

Length of output: 492


Ensure ARCH_SUFFIX is properly defined if using the architecture-parameterized download path.

The download uses $ARCH_SUFFIX but the variable is undefined in the script, and line 14 still hardcodes linux-amd64 for extraction. The workflow also runs the script without setting this variable, causing extraction to fail on non-amd64 architectures. Either define ARCH_SUFFIX at the script start and update both the download and extraction paths to use it, or keep both paths hardcoded as linux-amd64.

🧰 Tools
🪛 GitHub Actions: Dumpling

[error] 8-8: Shell script failed with syntax error: "redirection unexpected". Process completed with exit code 2.

🪛 Shellcheck (0.11.0)

[error] 8-8: Couldn't parse this here string. Fix to allow more checks.

(SC1073)


[info] 8-8: The mentioned syntax error was in this simple command.

(SC1009)


[error] 8-8: Fix any mentioned problems and try again.

(SC1072)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@dumpling/install.sh` around lines 8 - 12, The script uses an undefined
variable ARCH_SUFFIX in the wget URL and still hardcodes linux-amd64 for
extraction, causing failures on non-amd64 runs; fix by defining ARCH_SUFFIX near
the top (e.g., default ARCH_SUFFIX=${ARCH_SUFFIX:-amd64} or derive from uname
-m) and replace the hardcoded linux-amd64 in both the download URL and the tar
extraction command to use $ARCH_SUFFIX, ensuring TOOLS_TAG remains used as
before; alternatively, if multi-arch support is not intended, remove ARCH_SUFFIX
from the wget URL and make both download and extraction consistently use
linux-amd64.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

@wuhuizuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 189bf61 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 189bf61 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dumpling This is related to Dumpling of TiDB. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant