build: disable bazel test validations#67596
Conversation
|
@winoros I've received your pull request and will start the review. I'll conduct a thorough review covering code quality, potential issues, and implementation details. ⏳ This process typically takes 10-30 minutes depending on the complexity of the changes. ℹ️ Learn more details on Pantheon AI. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughModified Makefile test and coverage targets to use a new Bazel configuration variable Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #67596 +/- ##
================================================
- Coverage 77.5871% 77.4256% -0.1616%
================================================
Files 1981 1966 -15
Lines 547950 549313 +1363
================================================
+ Hits 425139 425309 +170
- Misses 122001 123987 +1986
+ Partials 810 17 -793
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
All is cached. Wait for cache invalidation. |
|
/hold |
|
one more try. |
commit ade4e1b Author: Yiding <winoros@gmail.com> Date: Thu Apr 9 19:52:06 2026 +0800 bazel_prepare commit fead675 Merge: 88ac540 997e75c Author: Yiding <winoros@gmail.com> Date: Thu Apr 9 18:59:33 2026 +0800 Merge branch 'master' into new-null-reject # Conflicts: # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_out.json # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_xut.json commit 88ac540 Merge: 790d28e 90dda82 Author: Yiding Cui <winoros@gmail.com> Date: Tue Apr 7 22:38:33 2026 +0800 Merge remote-tracking branch 'origin/master' into new-null-reject # Conflicts: # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_out.json # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_xut.json commit 790d28e Author: Yiding Cui <winoros@gmail.com> Date: Tue Apr 7 20:59:56 2026 +0800 fix test output commit 57e07c9 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 15:03:31 2026 +0800 change test result commit 5783407 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 15:03:21 2026 +0800 add comments commit e49bb07 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 14:25:09 2026 +0800 bazel_prepare commit 6058897 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:56:37 2026 +0800 planner/util: group null reject builtin registry by type commit 66d60ee Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:54:15 2026 +0800 add more null preserving functions commit aa2e799 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:28:30 2026 +0800 planner/util: fix typed null folding in null reject proof commit e49e10d Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:16:39 2026 +0800 planner/util: split null reject builtin tables commit b7c1719 Merge: 46181d5 2e1dffb Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 26 16:31:15 2026 +0800 Merge remote-tracking branch 'origin/master' into new-null-reject commit 46181d5 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 26 16:30:27 2026 +0800 planner: add issue 66824 null-reject unit case commit 24bbd68 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 26 16:10:03 2026 +0800 planner: add null reject proof comments commit 590101e Merge: 767d317 2c3290c Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 18:35:01 2026 +0800 Merge remote-tracking branch 'origin/master' into new-null-reject # Conflicts: # pkg/planner/core/casetest/rule/testdata/outer2inner_out.json # pkg/planner/core/casetest/rule/testdata/outer2inner_xut.json commit 767d317 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:50:41 2026 +0800 planner: stop treating FORMAT as null-preserving in null-reject proof commit 2e0f857 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:25:53 2026 +0800 docs,expression,tests: address nitpick comments commit 73eab0d Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:19:43 2026 +0800 planner: avoid leaking null-reject warnings commit 67bcb83 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:05:57 2026 +0800 planner: use null reject expr ctx in null misc commit 85bfa0d Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 01:50:19 2026 +0800 planner: fix lll lint in null_misc commit 38ba330 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 01:33:14 2026 +0800 add doc commit 088a8f0 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 01:02:42 2026 +0800 planner: fix null reject proof for field, quote and if commit f598772 Author: Yiding Cui <winoros@gmail.com> Date: Mon Mar 16 21:48:32 2026 +0800 planner: add null-reject regression tests commit 785f4e8 Author: Yiding Cui <winoros@gmail.com> Date: Mon Mar 16 21:47:51 2026 +0800 planner: replace outer-join null-reject evaluation with structural proof
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/planner/util/null_misc.go`:
- Around line 74-77: The call to MaybeOverOptimized4PlanCache inside
allConstants (and similar sites) ignores the skipPlanCacheCheck flag; thread the
skipPlanCacheCheck boolean through proveNullRejected → tryFoldNullifiedConstant
→ tryFoldStaticConstant → allConstants (and other affected locations) and only
call MaybeOverOptimized4PlanCache when skipPlanCacheCheck is false, so callers
that set skipPlanCacheCheck=true can bypass the plan-cache guard and still prove
null-rejection; update function signatures (e.g., proveNullRejected,
tryFoldNullifiedConstant, tryFoldStaticConstant, allConstants) to accept the
flag and propagate it accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5f011776-f6b0-4935-b19c-6a1c49d49deb
📒 Files selected for processing (22)
docs/design/2026-03-16-null-reject-proof-framework.mdpkg/expression/BUILD.bazelpkg/expression/builtin_registry.gopkg/planner/core/casetest/plancache/plan_cache_suite_test.gopkg/planner/core/casetest/rule/rule_outer2inner_test.gopkg/planner/core/casetest/rule/testdata/outer2inner_out.jsonpkg/planner/core/casetest/rule/testdata/outer2inner_xut.jsonpkg/planner/core/casetest/windows/testdata/window_push_down_suite_out.jsonpkg/planner/core/casetest/windows/testdata/window_push_down_suite_xut.jsonpkg/planner/core/operator/logicalop/BUILD.bazelpkg/planner/core/operator/logicalop/logical_join.gopkg/planner/core/partidx/check_constraint.gopkg/planner/util/BUILD.bazelpkg/planner/util/null_misc.gopkg/planner/util/null_misc_builtins.gopkg/planner/util/null_misc_test.gotests/integrationtest/r/planner/core/integration.resulttests/integrationtest/r/planner/core/plan_cache.resulttests/integrationtest/r/planner/core/rule_outer2inner.resulttests/integrationtest/t/planner/core/plan_cache.testtests/integrationtest/t/planner/core/rule_outer2inner.testtests/realtikvtest/pushdowntest/BUILD.bazel
💤 Files with no reviewable changes (1)
- pkg/planner/core/operator/logicalop/BUILD.bazel
✅ Files skipped from review due to trivial changes (4)
- pkg/planner/core/partidx/check_constraint.go
- pkg/expression/BUILD.bazel
- tests/realtikvtest/pushdowntest/BUILD.bazel
- tests/integrationtest/r/planner/core/integration.result
|
@winoros: The specified target(s) for Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test check-dev2 |
This reverts commit e9a2691.
|
don't read remote cache: 2h19m https://prow.tidb.net/jenkins/job/pingcap/job/tidb/job/ghpr_unit_test/544/stages/?selected-node=62 |
commit ade4e1b Author: Yiding <winoros@gmail.com> Date: Thu Apr 9 19:52:06 2026 +0800 bazel_prepare commit fead675 Merge: 88ac540 997e75c Author: Yiding <winoros@gmail.com> Date: Thu Apr 9 18:59:33 2026 +0800 Merge branch 'master' into new-null-reject # Conflicts: # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_out.json # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_xut.json commit 88ac540 Merge: 790d28e 90dda82 Author: Yiding Cui <winoros@gmail.com> Date: Tue Apr 7 22:38:33 2026 +0800 Merge remote-tracking branch 'origin/master' into new-null-reject # Conflicts: # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_out.json # pkg/planner/core/casetest/windows/testdata/window_push_down_suite_xut.json commit 790d28e Author: Yiding Cui <winoros@gmail.com> Date: Tue Apr 7 20:59:56 2026 +0800 fix test output commit 57e07c9 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 15:03:31 2026 +0800 change test result commit 5783407 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 15:03:21 2026 +0800 add comments commit e49bb07 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 14:25:09 2026 +0800 bazel_prepare commit 6058897 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:56:37 2026 +0800 planner/util: group null reject builtin registry by type commit 66d60ee Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:54:15 2026 +0800 add more null preserving functions commit aa2e799 Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:28:30 2026 +0800 planner/util: fix typed null folding in null reject proof commit e49e10d Author: Yiding Cui <winoros@gmail.com> Date: Fri Apr 3 13:16:39 2026 +0800 planner/util: split null reject builtin tables commit b7c1719 Merge: 46181d5 2e1dffb Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 26 16:31:15 2026 +0800 Merge remote-tracking branch 'origin/master' into new-null-reject commit 46181d5 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 26 16:30:27 2026 +0800 planner: add issue 66824 null-reject unit case commit 24bbd68 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 26 16:10:03 2026 +0800 planner: add null reject proof comments commit 590101e Merge: 767d317 2c3290c Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 18:35:01 2026 +0800 Merge remote-tracking branch 'origin/master' into new-null-reject # Conflicts: # pkg/planner/core/casetest/rule/testdata/outer2inner_out.json # pkg/planner/core/casetest/rule/testdata/outer2inner_xut.json commit 767d317 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:50:41 2026 +0800 planner: stop treating FORMAT as null-preserving in null-reject proof commit 2e0f857 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:25:53 2026 +0800 docs,expression,tests: address nitpick comments commit 73eab0d Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:19:43 2026 +0800 planner: avoid leaking null-reject warnings commit 67bcb83 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 03:05:57 2026 +0800 planner: use null reject expr ctx in null misc commit 85bfa0d Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 01:50:19 2026 +0800 planner: fix lll lint in null_misc commit 38ba330 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 01:33:14 2026 +0800 add doc commit 088a8f0 Author: Yiding Cui <winoros@gmail.com> Date: Thu Mar 19 01:02:42 2026 +0800 planner: fix null reject proof for field, quote and if commit f598772 Author: Yiding Cui <winoros@gmail.com> Date: Mon Mar 16 21:48:32 2026 +0800 planner: add null-reject regression tests commit 785f4e8 Author: Yiding Cui <winoros@gmail.com> Date: Mon Mar 16 21:47:51 2026 +0800 planner: replace outer-join null-reject evaluation with structural proof
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@winoros: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
with the remote cache, disabling static check seems that it doesn't help a lot. |
What problem does this PR solve?
Issue Number: ref #66760
Problem Summary:
One try.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit