docs: replace deprecated PingCAP domains (#67522)#69483
Conversation
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughUpdates BR test download helpers and Dumpling references to use ChangesPingCAP download domain update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-20251011 #69483 +/- ##
=============================================================
Coverage ? 71.8585%
=============================================================
Files ? 1835
Lines ? 494004
Branches ? 0
=============================================================
Hits ? 354984
Misses ? 115642
Partials ? 23378
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #67522
What problem does this PR solve?
Issue Number: close #67527
Problem Summary:
download.pingcap.orgis being deprecated in favor ofdownload.pingcap.com, but TiDB still has old-domain references in Dumpling install/docs and BR test download helpers onmaster.What changed and how does it work?
download.pingcap.orgreferences withdownload.pingcap.cominbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shmasterbehavior unchangedCheck List
Tests
Manual test steps:
git diff --checkbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shcurl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-master-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz#67527is labeledtype/compatibilitySide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
download.pingcap.comaddress.