Skip to content

docs: replace deprecated PingCAP domains (#67522)#69483

Open
ti-chi-bot wants to merge 3 commits into
pingcap:release-nextgen-20251011from
ti-chi-bot:cherry-pick-67522-to-release-nextgen-20251011
Open

docs: replace deprecated PingCAP domains (#67522)#69483
ti-chi-bot wants to merge 3 commits into
pingcap:release-nextgen-20251011from
ti-chi-bot:cherry-pick-67522-to-release-nextgen-20251011

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 26, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #67522

What problem does this PR solve?

Issue Number: close #67527

Problem Summary:

download.pingcap.org is being deprecated in favor of download.pingcap.com, but TiDB still has old-domain references in Dumpling install/docs and BR test download helpers on master.

What changed and how does it work?

  • replace deprecated download.pingcap.org references with download.pingcap.com in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • keep existing paths and current master behavior unchanged

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test steps:

  • git diff --check
  • verify no remaining old-domain references in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • curl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-master-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz
  • linked tracking issue #67527 is labeled type/compatibility

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

none

Summary by CodeRabbit

  • Bug Fixes
    • Updated download links for integration-test and installation resources to use the current download.pingcap.com address.
    • Improved reliability of fetching required archives and binaries by switching affected downloads to HTTPS.
    • Refreshed prerequisite instructions for related tooling to match the updated download locations.

wuhuizuo and others added 3 commits June 26, 2026 07:27
Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
@ti-chi-bot ti-chi-bot added component/dumpling This is related to Dumpling of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Jun 26, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd, yujuncen for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 95162a0e-7906-4087-a1c8-64aaa6d9cd49

📥 Commits

Reviewing files that changed from the base of the PR and between 31dfd0d and 52df463.

📒 Files selected for processing (3)
  • br/tests/download_tools.sh
  • dumpling/README.md
  • dumpling/install.sh

📝 Walkthrough

Walkthrough

Updates BR test download helpers and Dumpling references to use download.pingcap.com for the affected artifact URLs, with a small README license-line adjustment.

Changes

PingCAP download domain update

Layer / File(s) Summary
BR test downloads
br/tests/download_tools.sh
The nightly Tiflash, TiDB bundle, and CDC download commands now use download.pingcap.com.
Dumpling download references
dumpling/README.md, dumpling/install.sh
The README prerequisite links and the installer’s tidb-toolkit download URL switch to download.pingcap.com, and the README license line is adjusted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • pingcap/tidb#67522: Updates the same PingCAP download domains across BR and Dumpling download references.

Suggested labels

approved, lgtm

Suggested reviewers

  • D3Hunter
  • Leavrth

Poem

A bunny hopped by with a tiny green grin,
“New links, new hops, let the downloads begin! 🐇”
BR and Dumpling now point to the right door,
With cozy secure paths than before.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: replacing deprecated PingCAP domains in docs/scripts.
Description check ✅ Passed It follows the template with issue number, problem summary, changes, checklist, and release note.
Linked Issues check ✅ Passed It updates the three specified files to the new domain and keeps paths and behavior unchanged.
Out of Scope Changes check ✅ Passed No unrelated changes are present; edits are limited to the documented domain replacements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wuhuizuo wuhuizuo added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2026
@wuhuizuo

wuhuizuo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

/retest

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-nextgen-20251011@31dfd0d). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             release-nextgen-20251011     #69483   +/-   ##
=============================================================
  Coverage                            ?   71.8585%           
=============================================================
  Files                               ?       1835           
  Lines                               ?     494004           
  Branches                            ?          0           
=============================================================
  Hits                                ?     354984           
  Misses                              ?     115642           
  Partials                            ?      23378           
Flag Coverage Δ
unit 71.8585% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.3493% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 46.4902% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/dumpling This is related to Dumpling of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants