*: Downgrade unnecessary log(release-8.5) (#10465)

close #10467

Signed-off-by: JaySon-Huang <tshent@qq.com>

Author: JaySon-Huang

contrib/tiflash-proxy

@@ -108,7 +108,7 @@ void TableScanStatistics::collectExtraRuntimeDetail()
                     || remote_table_scan_detail.max_stream_cost_ns < this_execution_time)
                     remote_table_scan_detail.max_stream_cost_ns = this_execution_time;
                 if (remote_table_scan_detail.min_stream_cost_ns < 0.0 // not inited
-                    || remote_table_scan_detail.max_stream_cost_ns > this_execution_time)
+                    || remote_table_scan_detail.min_stream_cost_ns > this_execution_time)
                     remote_table_scan_detail.min_stream_cost_ns = this_execution_time;
             }
         });

dbms/src/Flash/Statistics/TableScanImpl.cpp

@@ -394,7 +394,7 @@ void SchemaBuilder<Getter, NameMapper>::applySetTiFlashReplica(DatabaseID databa
         auto storage = tmt_context.getStorages().get(keyspace_id, table_info->id);
         if (unlikely(storage == nullptr))
         {
-            LOG_ERROR(
+            LOG_WARNING(
                 log,
                 "Storage instance is not exist in TiFlash, applySetTiFlashReplica is ignored, table_id={}",
                 table_id);
@@ -523,12 +523,12 @@ void SchemaBuilder<Getter, NameMapper>::applyPartitionDiff(DatabaseID database_i
     auto table_info = getter.getTableInfo(database_id, table_id);
     if (unlikely(table_info == nullptr))
     {
-        LOG_ERROR(log, "table is not exist in TiKV, applyPartitionDiff is ignored, table_id={}", table_id);
+        LOG_WARNING(log, "table is not exist in TiKV, applyPartitionDiff is ignored, table_id={}", table_id);
         return;
     }
     if (!table_info->isLogicalPartitionTable())
     {
-        LOG_ERROR(
+        LOG_WARNING(
             log,
             "new table in TiKV is not a partition table {}, database_id={} table_id={}",
             name_mapper.debugCanonicalName(*table_info, database_id, keyspace_id),
@@ -541,7 +541,7 @@ void SchemaBuilder<Getter, NameMapper>::applyPartitionDiff(DatabaseID database_i
     auto storage = tmt_context.getStorages().get(keyspace_id, table_info->id);
     if (storage == nullptr)
     {
-        LOG_ERROR(
+        LOG_WARNING(
             log,
             "logical_table storage instance is not exist in TiFlash, applyPartitionDiff is ignored, table_id={}",
             table_id);
@@ -664,7 +664,7 @@ void SchemaBuilder<Getter, NameMapper>::applyRenameTable(DatabaseID database_id,
     auto new_table_info = getter.getTableInfo(database_id, table_id);
     if (unlikely(new_table_info == nullptr))
     {
-        LOG_ERROR(log, "table is not exist in TiKV, applyRenameTable is ignored, table_id={}", table_id);
+        LOG_WARNING(log, "table is not exist in TiKV, applyRenameTable is ignored, table_id={}", table_id);
         return;
     }
 
@@ -970,7 +970,7 @@ void SchemaBuilder<Getter, NameMapper>::applyRecoverDatabase(DatabaseID database
     auto db = context.tryGetDatabase(db_name);
     if (unlikely(!db))
     {
-        LOG_ERROR(
+        LOG_WARNING(
             log,
             "Recover database is ignored because instance is not exists, may have been physically dropped, "
             "database_id={}",

dbms/src/TiDB/Schema/SchemaBuilder.cpp

@@ -302,7 +302,7 @@ std::pair<TiDB::TableInfoPtr, bool> SchemaGetter::getTableInfoImpl(DatabaseID db
         get_by_mvcc = true;
         if (table_info_json.empty())
         {
-            LOG_ERROR(
+            LOG_WARNING(
                 log,
                 "The table is dropped in TiKV, and the latest table_info is still empty, it should be GCed, "
                 "table_id={}",
@@ -339,7 +339,7 @@ std::vector<TiDB::TableInfoPtr> SchemaGetter::listTables(DatabaseID db_id)
     auto db_key = getDBKey(db_id);
     if (!checkDBExists(db_key))
     {
-        LOG_ERROR(log, "The database does not exist, database_id={}", db_id);
+        LOG_WARNING(log, "The database does not exist, database_id={}", db_id);
         return {};
     }
 

dbms/src/TiDB/Schema/SchemaGetter.cpp

@@ -323,7 +323,7 @@ bool SchemaSyncService::gcImpl(Timestamp gc_safepoint, KeyspaceID keyspace_id, b
                     storage->getTombstone(),
                     gc_safepoint,
                     canonical_name);
-                succeeded = false; // dropping this table is skipped, do not succee the `last_gc_safepoint`
+                succeeded = false; // dropping this table is skipped, do not success the `last_gc_safepoint`
                 continue;
             }
             else
@@ -350,7 +350,7 @@ bool SchemaSyncService::gcImpl(Timestamp gc_safepoint, KeyspaceID keyspace_id, b
         drop_query->database = std::move(database_name);
         drop_query->table = std::move(table_name);
         drop_query->if_exists = true;
-        drop_query->lock_timeout = std::chrono::milliseconds(1 * 1000); // timeout for acquring table drop lock
+        drop_query->lock_timeout = std::chrono::milliseconds(1 * 1000); // timeout for acquiring table drop lock
         ASTPtr ast_drop_query = drop_query;
         try
         {
@@ -363,7 +363,7 @@ bool SchemaSyncService::gcImpl(Timestamp gc_safepoint, KeyspaceID keyspace_id, b
         }
         catch (DB::Exception & e)
         {
-            succeeded = false; // dropping this table is skipped, do not succee the `last_gc_safepoint`
+            succeeded = false; // dropping this table is skipped, do not success the `last_gc_safepoint`
             String err_msg;
             // Maybe a read lock of a table is held for a long time, just ignore it this round.
             if (e.code() == ErrorCodes::DEADLOCK_AVOIDED)
@@ -406,7 +406,7 @@ bool SchemaSyncService::gcImpl(Timestamp gc_safepoint, KeyspaceID keyspace_id, b
         auto drop_query = std::make_shared<ASTDropQuery>();
         drop_query->database = db_name;
         drop_query->if_exists = true;
-        drop_query->lock_timeout = std::chrono::milliseconds(1 * 1000); // timeout for acquring table drop lock
+        drop_query->lock_timeout = std::chrono::milliseconds(1 * 1000); // timeout for acquiring table drop lock
         ASTPtr ast_drop_query = drop_query;
         try
         {
@@ -417,7 +417,7 @@ bool SchemaSyncService::gcImpl(Timestamp gc_safepoint, KeyspaceID keyspace_id, b
         }
         catch (DB::Exception & e)
         {
-            succeeded = false; // dropping this database is skipped, do not succee the `last_gc_safepoint`
+            succeeded = false; // dropping this database is skipped, do not success the `last_gc_safepoint`
             String err_msg;
             if (e.code() == ErrorCodes::DEADLOCK_AVOIDED)
                 err_msg = "locking attempt has timed out!"; // ignore verbose stack for this error