Fix stale failure handler overwriting resolved approvals and migration pending count

- ProjectionPipeline: add early return when existingRow is already resolved
  in the stale failure code path, preventing decision from being overwritten
  with null on already-resolved approvals.

- Migration step 4: add AND status = 'pending' condition so stale failure
  backfill does not overwrite rows already resolved by earlier steps.

- Migration step 5: replace activity-based pending_approval_count derivation
  with a direct count from projection_pending_approvals WHERE status = 'pending',
  consistent with the runtime's refreshThreadShellSummary.

Applied via @cursor push command

Author: cursoragent

apps/server/src/orchestration/Layers/ProjectionPipeline.ts

@@ -1268,6 +1268,9 @@ const makeOrchestrationProjectionPipeline = Effect.fn("makeOrchestrationProjecti
               if (Option.isNone(existingRow)) {
                 return;
               }
+              if (existingRow.value.status === "resolved") {
+                return;
+              }
               yield* projectionPendingApprovalRepository.upsert({
                 requestId,
                 threadId: existingRow.value.threadId,

apps/server/src/persistence/Migrations/024_BackfillProjectionThreadShellSummary.ts

@@ -175,11 +175,12 @@ export default Effect.gen(function* () {
         FROM latest_stale_failures
         WHERE latest_stale_failures.request_id = projection_pending_approvals.request_id
       )
-    WHERE EXISTS (
-      SELECT 1
-      FROM latest_stale_failures
-      WHERE latest_stale_failures.request_id = projection_pending_approvals.request_id
-    )
+    WHERE status = 'pending'
+      AND EXISTS (
+        SELECT 1
+        FROM latest_stale_failures
+        WHERE latest_stale_failures.request_id = projection_pending_approvals.request_id
+      )
   `;
 
   yield* sql`
@@ -192,40 +193,10 @@ export default Effect.gen(function* () {
           AND message.role = 'user'
       ),
       pending_approval_count = COALESCE((
-        WITH latest_approval_states AS (
-          SELECT
-            latest.request_id,
-            latest.kind,
-            latest.detail
-          FROM (
-            SELECT
-              json_extract(activity.payload_json, '$.requestId') AS request_id,
-              activity.kind,
-              lower(COALESCE(json_extract(activity.payload_json, '$.detail'), '')) AS detail,
-              ROW_NUMBER() OVER (
-                PARTITION BY json_extract(activity.payload_json, '$.requestId')
-                ORDER BY activity.created_at DESC, activity.activity_id DESC
-              ) AS row_number
-            FROM projection_thread_activities AS activity
-            WHERE activity.thread_id = projection_threads.thread_id
-              AND json_extract(activity.payload_json, '$.requestId') IS NOT NULL
-              AND activity.kind IN (
-                'approval.requested',
-                'approval.resolved',
-                'provider.approval.respond.failed'
-              )
-          ) AS latest
-          WHERE latest.row_number = 1
-        )
         SELECT COUNT(*)
-        FROM latest_approval_states
-        WHERE latest_approval_states.kind = 'approval.requested'
-          OR (
-            latest_approval_states.kind = 'provider.approval.respond.failed'
-            AND latest_approval_states.detail NOT LIKE '%stale pending approval request%'
-            AND latest_approval_states.detail NOT LIKE '%unknown pending approval request%'
-            AND latest_approval_states.detail NOT LIKE '%unknown pending permission request%'
-          )
+        FROM projection_pending_approvals
+        WHERE projection_pending_approvals.thread_id = projection_threads.thread_id
+          AND projection_pending_approvals.status = 'pending'
       ), 0),
       pending_user_input_count = COALESCE((
         WITH latest_user_input_states AS (