Skip to content

Commit 0d4beff

Browse files
committed
Remove redundant assistant copy disabled state
- simplify assistant copy state to only track text and visibility - stop passing always-false disabled props to the copy button - update tests to match the narrower state shape
1 parent 3da865a commit 0d4beff

3 files changed

Lines changed: 0 additions & 7 deletions

File tree

apps/web/src/components/chat/MessagesTimeline.logic.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ describe("resolveAssistantMessageCopyState", () => {
158158
streaming: false,
159159
}),
160160
).toEqual({
161-
disabled: false,
162161
text: "Ship it",
163162
visible: true,
164163
});
@@ -172,7 +171,6 @@ describe("resolveAssistantMessageCopyState", () => {
172171
streaming: true,
173172
}),
174173
).toEqual({
175-
disabled: false,
176174
text: "Still streaming",
177175
visible: false,
178176
});
@@ -186,7 +184,6 @@ describe("resolveAssistantMessageCopyState", () => {
186184
streaming: false,
187185
}),
188186
).toEqual({
189-
disabled: false,
190187
text: null,
191188
visible: false,
192189
});
@@ -200,7 +197,6 @@ describe("resolveAssistantMessageCopyState", () => {
200197
streaming: false,
201198
}),
202199
).toEqual({
203-
disabled: false,
204200
text: "Interim thought",
205201
visible: false,
206202
});

apps/web/src/components/chat/MessagesTimeline.logic.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ export function resolveAssistantMessageCopyState({
7171
}) {
7272
const hasText = text !== null && text.trim().length > 0;
7373
return {
74-
disabled: false,
7574
text: hasText ? text : null,
7675
visible: showCopyButton && hasText && !streaming,
7776
};

apps/web/src/components/chat/MessagesTimeline.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -534,8 +534,6 @@ export const MessagesTimeline = memo(function MessagesTimeline({
534534
<MessageCopyButton
535535
text={assistantCopyState.text ?? ""}
536536
title="Copy assistant response"
537-
disabled={assistantCopyState.disabled}
538-
disabledTitle="Copy available when response completes"
539537
size="icon-xs"
540538
variant="outline"
541539
className="border-border/50 bg-background/35 text-muted-foreground/45 shadow-none hover:border-border/70 hover:bg-background/55 hover:text-muted-foreground/70"

0 commit comments

Comments
 (0)