Enable stricter Effect LSP rules (#2596)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: juliusmarminge

apps/desktop/src/backend/DesktopBackendManager.test.ts

@@ -15,7 +15,7 @@ import * as Schema from "effect/Schema";
 import * as Sink from "effect/Sink";
 import * as Scope from "effect/Scope";
 import * as Stream from "effect/Stream";
-import { TestClock } from "effect/testing";
+import * as TestClock from "effect/testing/TestClock";
 import { HttpClient, HttpClientRequest, HttpClientResponse } from "effect/unstable/http";
 import { ChildProcess, ChildProcessSpawner } from "effect/unstable/process";
 

apps/desktop/src/ssh/DesktopSshEnvironment.ts

@@ -3,7 +3,7 @@ import type {
   DesktopSshEnvironmentBootstrap,
   DesktopSshEnvironmentTarget,
 } from "@t3tools/contracts";
-import { type NetError, NetService } from "@t3tools/shared/Net";
+import * as NetService from "@t3tools/shared/Net";
 import {
   SshPasswordPrompt,
   type SshPasswordPromptShape,
@@ -35,7 +35,7 @@ export type DesktopSshEnvironmentRuntimeServices =
   | FileSystem.FileSystem
   | Path.Path
   | HttpClient.HttpClient
-  | NetService;
+  | NetService.NetService;
 
 export type DesktopSshEnvironmentOperationError =
   | SshCommandError
@@ -44,7 +44,7 @@ export type DesktopSshEnvironmentOperationError =
   | SshPairingError
   | SshReadinessError
   | SshPasswordPromptError
-  | NetError;
+  | NetService.NetError;
 
 export type DesktopSshEnvironmentDiscoverError = SshHostDiscoveryError;
 

apps/desktop/src/ssh/DesktopSshPasswordPrompts.test.ts

@@ -4,7 +4,7 @@ import * as Effect from "effect/Effect";
 import * as Fiber from "effect/Fiber";
 import * as Layer from "effect/Layer";
 import * as Option from "effect/Option";
-import { TestClock } from "effect/testing";
+import * as TestClock from "effect/testing/TestClock";
 import type * as Electron from "electron";
 
 import * as ElectronWindow from "../electron/ElectronWindow.ts";

apps/desktop/src/updates/DesktopUpdates.test.ts

@@ -8,7 +8,7 @@ import * as Effect from "effect/Effect";
 import * as Fiber from "effect/Fiber";
 import * as Layer from "effect/Layer";
 import * as Option from "effect/Option";
-import { TestClock } from "effect/testing";
+import * as TestClock from "effect/testing/TestClock";
 
 import * as DesktopBackendManager from "../backend/DesktopBackendManager.ts";
 import * as DesktopConfig from "../app/DesktopConfig.ts";

apps/desktop/tsconfig.json

@@ -3,19 +3,7 @@
   "compilerOptions": {
     "composite": true,
     "types": ["node", "electron"],
-    "lib": ["ESNext", "DOM", "esnext.disposable"],
-    "plugins": [
-      {
-        "name": "@effect/language-service",
-        "namespaceImportPackages": ["@effect/platform-node", "effect"],
-        "diagnosticSeverity": {
-          "importFromBarrel": "error",
-          "anyUnknownInErrorContext": "error",
-          "instanceOfSchema": "warning",
-          "deterministicKeys": "warning"
-        }
-      }
-    ]
+    "lib": ["ESNext", "DOM", "esnext.disposable"]
   },
   "include": ["src", "tsdown.config.ts"]
 }

apps/server/integration/OrchestrationEngineHarness.integration.ts

@@ -1,3 +1,4 @@
+// @effect-diagnostics nodeBuiltinImport:off
 import { execFileSync } from "node:child_process";
 
 import * as NodeServices from "@effect/platform-node/NodeServices";
@@ -8,20 +9,18 @@ import {
   type OrchestrationEvent,
   type OrchestrationThread,
 } from "@t3tools/contracts";
-import {
-  Effect,
-  Exit,
-  FileSystem,
-  Layer,
-  ManagedRuntime,
-  Option,
-  Path,
-  Ref,
-  Schedule,
-  Schema,
-  Scope,
-  Stream,
-} from "effect";
+import * as Effect from "effect/Effect";
+import * as Exit from "effect/Exit";
+import * as FileSystem from "effect/FileSystem";
+import * as Layer from "effect/Layer";
+import * as ManagedRuntime from "effect/ManagedRuntime";
+import * as Option from "effect/Option";
+import * as Path from "effect/Path";
+import * as Ref from "effect/Ref";
+import * as Schedule from "effect/Schedule";
+import * as Schema from "effect/Schema";
+import * as Scope from "effect/Scope";
+import * as Stream from "effect/Stream";
 
 import { CheckpointStoreLive } from "../src/checkpointing/Layers/CheckpointStore.ts";
 import { CheckpointStore } from "../src/checkpointing/Services/CheckpointStore.ts";

apps/server/integration/TestProviderAdapter.integration.ts

@@ -1,5 +1,3 @@
-import { randomUUID } from "node:crypto";
-
 import {
   ApprovalRequestId,
   EventId,
@@ -12,7 +10,10 @@ import {
   TurnId,
   ProviderDriverKind,
 } from "@t3tools/contracts";
-import { Effect, Queue, Stream } from "effect";
+import * as Effect from "effect/Effect";
+import * as Queue from "effect/Queue";
+import * as Random from "effect/Random";
+import * as Stream from "effect/Stream";
 
 import {
   ProviderAdapterSessionNotFoundError,
@@ -202,7 +203,7 @@ interface MakeTestProviderAdapterHarnessOptions {
 }
 
 function nowIso(): string {
-  return new Date().toISOString();
+  return "2026-01-01T00:00:00.000Z";
 }
 
 function sessionNotFound(
@@ -308,10 +309,9 @@ export const makeTestProviderAdapterHarness = (options?: MakeTestProviderAdapter
         for (const fixtureEvent of response.events) {
           const rawEvent: Record<string, unknown> = {
             ...(fixtureEvent as Record<string, unknown>),
-            eventId: randomUUID(),
+            eventId: yield* Random.nextUUIDv4,
             provider,
             sessionId: RuntimeSessionId.make(String(input.threadId)),
-            createdAt: nowIso(),
           };
           rawEvent.threadId = state.snapshot.threadId;
           if (Object.hasOwn(rawEvent, "turnId")) {
@@ -366,7 +366,7 @@ export const makeTestProviderAdapterHarness = (options?: MakeTestProviderAdapter
         if (deferredTurnCompletedEvents.length === 0) {
           yield* emit({
             type: "turn.completed",
-            eventId: EventId.make(randomUUID()),
+            eventId: EventId.make(yield* Random.nextUUIDv4),
             provider,
             createdAt: nowIso(),
             threadId: state.snapshot.threadId,

apps/server/integration/orchestrationEngine.integration.test.ts

@@ -1,3 +1,4 @@
+// @effect-diagnostics nodeBuiltinImport:off
 import fs from "node:fs";
 import path from "node:path";
 
@@ -17,7 +18,10 @@ import {
   ProviderInstanceId,
 } from "@t3tools/contracts";
 import { assert, it } from "@effect/vitest";
-import { Effect, Option, Schema } from "effect";
+import * as Clock from "effect/Clock";
+import * as Effect from "effect/Effect";
+import * as Option from "effect/Option";
+import * as Schema from "effect/Schema";
 
 import type { TestTurnResponse } from "./TestProviderAdapter.integration.ts";
 import {
@@ -47,7 +51,7 @@ const CODEX_PROVIDER = ProviderDriverKind.make("codex");
 const CLAUDE_AGENT_PROVIDER = ProviderDriverKind.make("claudeAgent");
 
 function nowIso() {
-  return new Date().toISOString();
+  return "2026-05-01T00:00:00.000Z";
 }
 
 class IntegrationWaitTimeoutError extends Schema.TaggedErrorClass<IntegrationWaitTimeoutError>()(
@@ -64,14 +68,14 @@ function waitForSync<A>(
   timeoutMs = 10_000,
 ): Effect.Effect<A, never> {
   return Effect.gen(function* () {
-    const deadline = Date.now() + timeoutMs;
+    const deadline = (yield* Clock.currentTimeMillis) + timeoutMs;
 
     while (true) {
       const value = read();
       if (predicate(value)) {
         return value;
       }
-      if (Date.now() >= deadline) {
+      if ((yield* Clock.currentTimeMillis) >= deadline) {
         return yield* Effect.die(new IntegrationWaitTimeoutError({ description }));
       }
       yield* Effect.sleep(10);
@@ -156,6 +160,7 @@ const startTurn = (input: {
   readonly messageId: string;
   readonly text: string;
   readonly modelSelection?: ModelSelection;
+  readonly createdAt?: string;
 }) =>
   input.harness.engine.dispatch({
     type: "thread.turn.start",
@@ -174,7 +179,7 @@ const startTurn = (input: {
       : {}),
     interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
     runtimeMode: "approval-required",
-    createdAt: nowIso(),
+    createdAt: input.createdAt ?? nowIso(),
   });
 
 it.live("runs a single turn end-to-end and persists checkpoint state in sqlite + git", () =>
@@ -755,6 +760,7 @@ it.live("reverts to an earlier checkpoint and trims checkpoint projections + git
         commandId: "cmd-turn-start-revert-1",
         messageId: "msg-user-revert-1",
         text: "First edit",
+        createdAt: "2026-02-24T10:04:59.900Z",
       });
 
       yield* harness.waitForThread(
@@ -813,6 +819,7 @@ it.live("reverts to an earlier checkpoint and trims checkpoint projections + git
         commandId: "cmd-turn-start-revert-2",
         messageId: "msg-user-revert-2",
         text: "Second edit",
+        createdAt: "2026-02-24T10:05:00.900Z",
       });
 
       yield* harness.waitForThread(

apps/server/integration/providerService.integration.test.ts

@@ -3,7 +3,12 @@ import { ProviderDriverKind, ProviderInstanceId, ThreadId } from "@t3tools/contr
 import { DEFAULT_SERVER_SETTINGS } from "@t3tools/contracts/settings";
 import * as NodeServices from "@effect/platform-node/NodeServices";
 import { it, assert } from "@effect/vitest";
-import { Effect, FileSystem, Layer, Path, Queue, Stream } from "effect";
+import * as Effect from "effect/Effect";
+import * as FileSystem from "effect/FileSystem";
+import * as Layer from "effect/Layer";
+import * as Path from "effect/Path";
+import * as Queue from "effect/Queue";
+import * as Stream from "effect/Stream";
 
 import { ProviderAdapterRegistry } from "../src/provider/Services/ProviderAdapterRegistry.ts";
 import { makeAdapterRegistryMock } from "../src/provider/testUtils/providerAdapterRegistryMock.ts";

apps/server/scripts/acp-mock-agent.ts

@@ -1,4 +1,5 @@
 #!/usr/bin/env bun
+// @effect-diagnostics nodeBuiltinImport:off
 import { appendFileSync } from "node:fs";
 
 import * as Effect from "effect/Effect";