fix(server): support Windows provider paths with spaces

Run Windows provider probes through a shell command string so custom binary paths containing spaces are quoted the way cmd.exe expects.

Author: raulpesilva

apps/server/src/provider/Layers/ProviderRegistry.test.ts

@@ -46,21 +46,11 @@ function unwrapWindowsProviderCommand(
   command: string,
   args: ReadonlyArray<string>,
 ): { command: string; args: ReadonlyArray<string> } {
-  const comSpec = process.env.ComSpec ?? "cmd.exe";
-  if (command !== comSpec || args.length !== 5) {
+  if (args.length > 0) {
     return { command, args };
   }
 
-  const [u, d, s, c, shellCommand] = args;
-  if (u !== "/u" || d !== "/d" || s !== "/s" || c !== "/c") {
-    return { command, args };
-  }
-
-  if (!shellCommand) {
-    return { command, args };
-  }
-
-  const parts = shellCommand.split(" ");
+  const parts = command.split(" ");
   return {
     command: parts[0] ?? command,
     args: parts.slice(1),

apps/server/src/provider/providerSnapshot.test.ts

@@ -1,7 +1,11 @@
 import { Effect, Stream } from "effect";
 import { afterEach, describe, expect, it, vi } from "vitest";
 
-import { collectStreamAsString, quoteWindowsShellArgument } from "./providerSnapshot";
+import {
+  collectStreamAsString,
+  makeProviderCommand,
+  quoteWindowsShellArgument,
+} from "./providerSnapshot";
 
 afterEach(() => {
   vi.unstubAllGlobals();
@@ -44,3 +48,20 @@ describe("quoteWindowsShellArgument", () => {
     );
   });
 });
+
+describe("makeProviderCommand", () => {
+  it("uses a shell command string for Windows paths with spaces", () => {
+    vi.stubGlobal("process", { ...process, platform: "win32" });
+
+    const command = makeProviderCommand("C:\\Program Files\\Codex\\codex.exe", ["--version"]);
+    const resolved = command as unknown as {
+      command: string;
+      args: ReadonlyArray<string>;
+      options: { shell?: boolean };
+    };
+
+    expect(resolved.command).toBe('"C:\\Program Files\\Codex\\codex.exe" --version');
+    expect(resolved.args).toEqual([]);
+    expect(resolved.options.shell).toBe(true);
+  });
+});

apps/server/src/provider/providerSnapshot.ts

@@ -70,14 +70,10 @@ export function makeProviderCommand(
     ...args.map(quoteWindowsShellArgument),
   ].join(" ");
 
-  return ChildProcess.make(
-    process.env.ComSpec ?? "cmd.exe",
-    ["/u", "/d", "/s", "/c", shellCommand],
-    {
-      shell: false,
-      env: options?.env,
-    },
-  );
+  return ChildProcess.make(shellCommand, [], {
+    shell: true,
+    env: options?.env,
+  });
 }
 
 function decodeProcessOutput(output: Uint8Array): string {