Skip to content

Commit 2fce84a

Browse files
authored
fix: quote editor launch args on Windows to support paths with spaces (#1805)
1 parent f9019cd commit 2fce84a

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

apps/server/src/open.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,11 +293,16 @@ export const launchDetached = (launch: EditorLaunch) =>
293293
yield* Effect.callback<void, OpenError>((resume) => {
294294
let child;
295295
try {
296-
child = spawn(launch.command, [...launch.args], {
297-
detached: true,
298-
stdio: "ignore",
299-
shell: process.platform === "win32",
300-
});
296+
const isWin32 = process.platform === "win32";
297+
child = spawn(
298+
launch.command,
299+
isWin32 ? launch.args.map((a) => `"${a}"`) : [...launch.args],
300+
{
301+
detached: true,
302+
stdio: "ignore",
303+
shell: isWin32,
304+
},
305+
);
301306
} catch (error) {
302307
return resume(
303308
Effect.fail(new OpenError({ message: "failed to spawn detached process", cause: error })),

0 commit comments

Comments
 (0)