Hide assistant copy button until streaming completes

Author: shivamhwp

apps/web/src/components/chat/MessageCopyButton.tsx

@@ -10,7 +10,6 @@ export const MessageCopyButton = memo(function MessageCopyButton({
   size = "xs",
   variant = "outline",
   className,
-  disabled = false,
   onCopy,
   onError,
 }: {
@@ -19,7 +18,6 @@ export const MessageCopyButton = memo(function MessageCopyButton({
   size?: "xs" | "icon-xs";
   variant?: "outline" | "ghost";
   className?: string;
-  disabled?: boolean;
   onCopy?: () => void;
   onError?: (error: Error) => void;
 }) {
@@ -35,7 +33,6 @@ export const MessageCopyButton = memo(function MessageCopyButton({
       size={size}
       variant={variant}
       className={cn(className)}
-      disabled={disabled}
       onClick={() => copyToClipboard(text, undefined)}
       title={buttonTitle}
       aria-label={buttonTitle}

apps/web/src/components/chat/MessagesTimeline.logic.test.ts

@@ -158,37 +158,21 @@ describe("resolveAssistantMessageCopyState", () => {
         streaming: false,
       }),
     ).toEqual({
-      disabled: false,
       text: "Ship it",
       visible: true,
     });
   });
 
-  it("keeps copy visible but disabled while an assistant message is still streaming", () => {
+  it("hides copy while an assistant message is still streaming", () => {
     expect(
       resolveAssistantMessageCopyState({
         showCopyButton: true,
         text: "Still streaming",
         streaming: true,
       }),
     ).toEqual({
-      disabled: true,
       text: "Still streaming",
-      visible: true,
-    });
-  });
-
-  it("keeps copy visible while a terminal assistant message is streaming before text arrives", () => {
-    expect(
-      resolveAssistantMessageCopyState({
-        showCopyButton: true,
-        text: "",
-        streaming: true,
-      }),
-    ).toEqual({
-      disabled: true,
-      text: null,
-      visible: true,
+      visible: false,
     });
   });
 
@@ -200,7 +184,6 @@ describe("resolveAssistantMessageCopyState", () => {
         streaming: false,
       }),
     ).toEqual({
-      disabled: false,
       text: null,
       visible: false,
     });
@@ -214,7 +197,6 @@ describe("resolveAssistantMessageCopyState", () => {
         streaming: false,
       }),
     ).toEqual({
-      disabled: false,
       text: "Interim thought",
       visible: false,
     });

apps/web/src/components/chat/MessagesTimeline.logic.ts

@@ -72,8 +72,7 @@ export function resolveAssistantMessageCopyState({
   const hasText = text !== null && text.trim().length > 0;
   return {
     text: hasText ? text : null,
-    visible: showCopyButton && (hasText || streaming),
-    disabled: streaming,
+    visible: showCopyButton && hasText && !streaming,
   };
 }
 

apps/web/src/components/chat/MessagesTimeline.test.tsx

@@ -109,7 +109,7 @@ describe("MessagesTimeline", () => {
     expect(markup).toContain("Work log");
   });
 
-  it("renders the assistant copy button in a disabled state while streaming", async () => {
+  it("does not render the assistant copy button while streaming", async () => {
     const { MessagesTimeline } = await import("./MessagesTimeline");
     const markup = renderToStaticMarkup(
       <MessagesTimeline
@@ -154,7 +154,6 @@ describe("MessagesTimeline", () => {
       />,
     );
 
-    expect(markup).toContain('aria-label="Copy assistant response"');
-    expect(markup).toContain("disabled");
+    expect(markup).not.toContain('aria-label="Copy assistant response"');
   }, 10_000);
 });

apps/web/src/components/chat/MessagesTimeline.tsx

@@ -537,7 +537,6 @@ export const MessagesTimeline = memo(function MessagesTimeline({
                         size="icon-xs"
                         variant="outline"
                         className="border-border/50 bg-background/35 text-muted-foreground/45 shadow-none hover:border-border/70 hover:bg-background/55 hover:text-muted-foreground/70"
-                        disabled={assistantCopyState.disabled}
                         onCopy={() => {
                           toastManager.add({
                             type: "success",