Remove unnecessary git checkout scope requirement

Author: Marve10s

apps/server/src/git/Layers/GitCore.ts

@@ -2190,16 +2190,14 @@ export const makeGitCore = Effect.fn("makeGitCore")(function* (options?: {
       fallbackErrorMessage: "git branch create failed",
     });
     if (input.checkout) {
-      yield* Effect.scoped(
-        checkoutBranch({ cwd: input.cwd, branch: input.branch }).pipe(
-          Effect.catchTag("GitCheckoutDirtyWorktreeError", (e) =>
-            Effect.fail(
-              createGitCommandError(
-                "GitCore.createBranch.checkout",
-                input.cwd,
-                ["checkout", input.branch],
-                e.message,
-              ),
+      yield* checkoutBranch({ cwd: input.cwd, branch: input.branch }).pipe(
+        Effect.catchTag("GitCheckoutDirtyWorktreeError", (e) =>
+          Effect.fail(
+            createGitCommandError(
+              "GitCore.createBranch.checkout",
+              input.cwd,
+              ["checkout", input.branch],
+              e.message,
             ),
           ),
         ),

apps/server/src/git/Layers/GitManager.ts

@@ -1529,7 +1529,7 @@ export const makeGitManager = Effect.fn("makeGitManager")(function* () {
     const resolvedBranch = resolveAutoFeatureBranchName(existingBranchNames, preferredBranch);
 
     yield* gitCore.createBranch({ cwd, branch: resolvedBranch });
-    yield* Effect.scoped(gitCore.checkoutBranch({ cwd, branch: resolvedBranch }));
+    yield* gitCore.checkoutBranch({ cwd, branch: resolvedBranch });
 
     return {
       branchStep: { status: "created" as const, name: resolvedBranch },

apps/server/src/git/Services/GitCore.ts

@@ -7,7 +7,7 @@
  * @module GitCore
  */
 import { Context } from "effect";
-import type { Effect, Scope } from "effect";
+import type { Effect } from "effect";
 import type {
   GitCheckoutInput,
   GitCheckoutResult,
@@ -294,15 +294,9 @@ export interface GitCoreShape {
    */
   readonly checkoutBranch: (
     input: GitCheckoutInput,
-  ) => Effect.Effect<
-    GitCheckoutResult,
-    GitCommandError | GitCheckoutDirtyWorktreeError,
-    Scope.Scope
-  >;
+  ) => Effect.Effect<GitCheckoutResult, GitCommandError | GitCheckoutDirtyWorktreeError>;
 
-  readonly stashAndCheckout: (
-    input: GitCheckoutInput,
-  ) => Effect.Effect<void, GitCommandError, Scope.Scope>;
+  readonly stashAndCheckout: (input: GitCheckoutInput) => Effect.Effect<void, GitCommandError>;
 
   readonly stashDrop: (cwd: string) => Effect.Effect<void, GitCommandError>;