Clear VCS presentation state on finish (#3764)

Author: juliusmarminge

packages/client-runtime/src/state/vcsAction.test.ts

@@ -155,6 +155,46 @@ describe("vcsActionState", () => {
     });
   });
 
+  it("clears running presentation state once the action finishes", () => {
+    const initial = beginVcsActionState({
+      operation: "run_change_request",
+      label: "Running source control action",
+      actionId,
+    });
+    const pushing = applyVcsActionProgressEvent(
+      initial,
+      progress({
+        actionId,
+        action,
+        cwd,
+        kind: "phase_started",
+        phase: "push",
+        label: "Pushing...",
+      }),
+    );
+    const finished = applyVcsActionProgressEvent(
+      pushing,
+      progress({
+        actionId,
+        action,
+        cwd,
+        kind: "action_finished",
+        result,
+      }),
+    );
+
+    expect(finished).toMatchObject({
+      isRunning: false,
+      operation: "run_change_request",
+      actionId,
+      action,
+      currentLabel: null,
+      currentPhaseLabel: null,
+      lastOutputLine: null,
+      error: null,
+    });
+  });
+
   it("retains a terminal action error for presentation", () => {
     const initial = beginVcsActionState({
       operation: "run_change_request",

packages/client-runtime/src/state/vcsAction.ts

@@ -386,12 +386,10 @@ export function applyVcsActionProgressEvent(
       };
     case "action_finished":
       return {
-        ...current,
-        isRunning: false,
+        ...EMPTY_VCS_ACTION_STATE,
         actionId: event.actionId,
         action: event.action,
         operation: "run_change_request",
-        error: null,
       };
     case "action_failed":
       return {