address base path review comments

Author: tarik02

apps/web/src/components/SplashScreen.tsx

@@ -1,8 +1,14 @@
+import { BASE_PATH } from "../basePath";
+
 export function SplashScreen() {
   return (
     <div className="flex min-h-screen items-center justify-center bg-background">
       <div className="flex size-24 items-center justify-center" aria-label="T3 Code splash screen">
-        <img alt="T3 Code" className="size-16 object-contain" src="./apple-touch-icon.png" />
+        <img
+          alt="T3 Code"
+          className="size-16 object-contain"
+          src={`${BASE_PATH}/apple-touch-icon.png`}
+        />
       </div>
     </div>
   );

packages/client-runtime/src/advertisedEndpoint.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest";
 
+import { NormalizedBasePath } from "@t3tools/shared/basePath";
 import {
   classifyHostedHttpsCompatibility,
   createAdvertisedEndpoint,
@@ -16,14 +17,23 @@ const coreProvider = {
 
 describe("advertised endpoint helpers", () => {
   it("normalizes HTTP and WebSocket base URLs", () => {
-    expect(normalizeHttpBaseUrl("https://example.com/path?x=1#hash")).toBe(
-      "https://example.com/path/",
-    );
-    expect(normalizeHttpBaseUrl("wss://example.com/socket")).toBe("https://example.com/socket/");
-    expect(deriveWsBaseUrl("https://example.com/api")).toBe("wss://example.com/api/");
+    expect(normalizeHttpBaseUrl("https://example.com/path?x=1#hash")).toBe("https://example.com/");
+    expect(normalizeHttpBaseUrl("wss://example.com/socket")).toBe("https://example.com/");
+    expect(deriveWsBaseUrl("https://example.com/api")).toBe("wss://example.com/");
     expect(deriveWsBaseUrl("http://127.0.0.1:3773")).toBe("ws://127.0.0.1:3773/");
   });
 
+  it("uses explicit base path when provided", () => {
+    const basePath = NormalizedBasePath("/custom");
+
+    expect(normalizeHttpBaseUrl("https://example.com/path?x=1#hash", { basePath })).toBe(
+      "https://example.com/custom/",
+    );
+    expect(deriveWsBaseUrl("https://example.com/api", { basePath })).toBe(
+      "wss://example.com/custom/",
+    );
+  });
+
   it("marks HTTP endpoints as blocked from hosted HTTPS apps", () => {
     expect(classifyHostedHttpsCompatibility("http://192.168.1.44:3773")).toBe(
       "mixed-content-blocked",

packages/shared/src/advertisedEndpoint.ts

@@ -6,9 +6,8 @@ import type {
   AdvertisedEndpointSource,
   AdvertisedEndpointStatus,
 } from "@t3tools/contracts";
-import * as Effect from "effect/Effect";
 
-import { normalizeBasePath, type NormalizedBasePath } from "./basePath.ts";
+import { ROOT_BASE_PATH, type NormalizedBasePath } from "./basePath.ts";
 
 export interface CreateAdvertisedEndpointInput {
   readonly id: string;
@@ -42,7 +41,7 @@ export function normalizeHttpBaseUrl(
   if (url.protocol !== "http:" && url.protocol !== "https:") {
     throw new Error(`Endpoint must use HTTP or HTTPS. Received ${url.protocol}`);
   }
-  url.pathname = `${options?.basePath ?? Effect.runSync(normalizeBasePath(url.pathname))}/`;
+  url.pathname = `${options?.basePath ?? ROOT_BASE_PATH}/`;
   url.search = "";
   url.hash = "";
   return url.toString();