Skip to content

Commit 9c61299

Browse files
Preserve composer skill state and simplify menu refs
- Restore serialized composer skill node state - Sync skill labels before paint to avoid stale UI - Keep composer menu refs current during render
1 parent fa0f3f8 commit 9c61299

3 files changed

Lines changed: 5 additions & 20 deletions

File tree

apps/server/src/provider/codexAppServer.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -244,16 +244,3 @@ export async function probeCodexDiscovery(input: {
244244
});
245245
});
246246
}
247-
248-
export async function probeCodexAccount(input: {
249-
readonly binaryPath: string;
250-
readonly homePath?: string;
251-
readonly signal?: AbortSignal;
252-
}): Promise<CodexAccountSnapshot> {
253-
return (
254-
await probeCodexDiscovery({
255-
...input,
256-
cwd: process.cwd(),
257-
})
258-
).account;
259-
}

apps/web/src/components/ComposerPromptEditor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ class ComposerSkillNode extends TextNode {
237237
return $createComposerSkillNode(
238238
serializedNode.skillName,
239239
serializedNode.skillLabel ?? serializedNode.skillName,
240-
);
240+
).updateFromJSON(serializedNode);
241241
}
242242

243243
constructor(skillName: string, skillLabel: string, key?: NodeKey) {
@@ -1401,7 +1401,7 @@ function ComposerPromptEditorInner({
14011401
onChangeRef.current = onChange;
14021402
}, [onChange]);
14031403

1404-
useEffect(() => {
1404+
useLayoutEffect(() => {
14051405
skillsByNameRef.current = skillLabelByName(skills);
14061406
}, [skills]);
14071407

apps/web/src/components/chat/ChatComposer.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -817,11 +817,9 @@ export const ChatComposer = memo(
817817
[composerHighlightedItemId, composerMenuItems],
818818
);
819819

820-
useEffect(() => {
821-
composerMenuOpenRef.current = composerMenuOpen;
822-
composerMenuItemsRef.current = composerMenuItems;
823-
activeComposerMenuItemRef.current = activeComposerMenuItem;
824-
}, [activeComposerMenuItem, composerMenuItems, composerMenuOpen]);
820+
composerMenuOpenRef.current = composerMenuOpen;
821+
composerMenuItemsRef.current = composerMenuItems;
822+
activeComposerMenuItemRef.current = activeComposerMenuItem;
825823

826824
const nonPersistedComposerImageIdSet = useMemo(
827825
() => new Set(nonPersistedComposerImageIds),

0 commit comments

Comments
 (0)