Skip to content

Refactor sidebar rerender boundaries anad reduce the re-renders #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justsomelegs wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor sidebar rerender boundaries anad reduce the re-renders #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
967e470
Refactor sidebar rerender boundaries
justsomelegs Apr 10, 2026
77aef32
Polish sidebar atomic selectors and controllers
justsomelegs Apr 10, 2026
5eff638
Finalize sidebar cleanup and selector narrowing
justsomelegs Apr 10, 2026
6aea4a2
Harden sidebar controllers and view state
justsomelegs Apr 10, 2026
96b3810
Tighten sidebar controller subscriptions
justsomelegs Apr 10, 2026
7ab18ad
Finalize sidebar key typing
justsomelegs Apr 10, 2026
e0f8c88
Merge branch 'main' into legs/sidebar-rerenders
justsomelegs Apr 10, 2026
52aed4d
fixes from suggestions
justsomelegs Apr 10, 2026
aebb3d8
fix fmt issues
justsomelegs Apr 10, 2026
6f1805a
fix typecheck :)
justsomelegs Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions apps/web/src/components/Sidebar.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { cn } from "../lib/utils";
import { isLatestTurnSettled } from "../session-logic";

export const THREAD_SELECTION_SAFE_SELECTOR = "[data-thread-item], [data-thread-selection-safe]";
export const THREAD_JUMP_HINT_SHOW_DELAY_MS = 100;
export const THREAD_JUMP_HINT_SHOW_DELAY_MS = 75;
export type SidebarNewThreadEnvMode = "local" | "worktree";
type SidebarProject = {
id: string;
Expand All @@ -14,6 +14,7 @@ type SidebarProject = {
updatedAt?: string | undefined;
};
type SidebarThreadSortInput = Pick<Thread, "createdAt" | "updatedAt"> & {
projectId: string;
latestUserMessageAt?: string | null;
messages?: Pick<Thread["messages"][number], "createdAt" | "role">[];
};
Expand Down Expand Up @@ -44,16 +45,28 @@ const THREAD_STATUS_PRIORITY: Record<ThreadStatusPill["label"], number> = {

type ThreadStatusInput = Pick<
SidebarThreadSummary,
| "hasActionableProposedPlan"
| "hasPendingApprovals"
| "hasPendingUserInput"
| "interactionMode"
| "latestTurn"
| "session"
"hasActionableProposedPlan" | "hasPendingApprovals" | "hasPendingUserInput" | "interactionMode"
> & {
latestTurn: ThreadStatusLatestTurnSnapshot | null;
session: ThreadStatusSessionSnapshot | null;
lastVisitedAt?: string | undefined;
};

type LatestTurnSnapshot = NonNullable<SidebarThreadSummary["latestTurn"]>;
type SessionSnapshot = NonNullable<SidebarThreadSummary["session"]>;

export interface ThreadStatusLatestTurnSnapshot {
turnId: LatestTurnSnapshot["turnId"];
startedAt: LatestTurnSnapshot["startedAt"];
completedAt: LatestTurnSnapshot["completedAt"];
}

export interface ThreadStatusSessionSnapshot {
orchestrationStatus: SessionSnapshot["orchestrationStatus"];
activeTurnId?: SessionSnapshot["activeTurnId"];
status: SessionSnapshot["status"];
}

export interface ThreadJumpHintVisibilityController {
sync: (shouldShow: boolean) => void;
dispose: () => void;
Expand Down Expand Up @@ -541,7 +554,7 @@ export function getProjectSortTimestamp(

export function sortProjectsForSidebar<
TProject extends SidebarProject,
TThread extends Pick<Thread, "projectId" | "createdAt" | "updatedAt"> & SidebarThreadSortInput,
TThread extends SidebarThreadSortInput,
>(
projects: readonly TProject[],
threads: readonly TThread[],
Expand Down
Loading
Loading