Make DrainableWorker keyed by thread#1955
Closed
ashvinnihalani wants to merge 1 commit intopingdotgg:mainfrom
Closed
Make DrainableWorker keyed by thread#1955ashvinnihalani wants to merge 1 commit intopingdotgg:mainfrom
ashvinnihalani wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DrainableWorkerprocess items serially per thread key while allowing different keys to run concurrentlythreadIddrainKeyfromDrainableWorker, document that we do not support per-key draining yet, and add regression coverage for blocked-thread isolationTesting
bun fmtbun lintbun typecheckbun run test -- src/DrainableWorker.test.tsbun run test -- src/orchestration/Layers/ProviderCommandReactor.test.tsNote
Key
DrainableWorkerby thread to allow concurrent cross-thread processingDrainableWorkerfrom a single-queue design to a per-key design usingTxRef-managed state, where each key gets its own serial queue but different keys run concurrently.enqueueto accept(key, item)and the process function to receive(key, item);drainnow waits for all keys' work to complete.CheckpointReactor,ProviderCommandReactor, andProviderRuntimeIngestionto enqueue withthreadIdas the key.enqueuenow requires a key argument at all call sites; work for different threads proceeds concurrently while preserving per-thread ordering.Macroscope summarized 343bd81.