Use more idiomatic Effect APIs in VCS config and diagnostics#2801
Draft
cursor[bot] wants to merge 2 commits into
Draft
Use more idiomatic Effect APIs in VCS config and diagnostics#2801cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.t3code/vcs.jsonthroughSchema.fromJsonStringinstead ofJSON.parseplus manual schema checks.Optionfrom VCS config discovery/read failure paths instead ofnullsentinels.Duration/Scheduleprimitives instead of a manual millisecond sleep loop.Why
These are small, production-path improvements that align the codebase with idiomatic Effect patterns while preserving existing fallback behavior.
UI Changes
None.
Checklist
Note
Use idiomatic Effect APIs in VCS config and diagnostics
JSON.parse+Schema.isguard in VcsProjectConfig.ts withSchema.decodeUnknownEffectandEffect.optionfor cleaner decode-or-fallback logicfindConfigPathto returnOption<string>andreadConfiguredKindto returnOptionvalues, eliminating nullable returnsforever+sleeploop in ProcessResourceMonitor.ts withEffect.repeat(Schedule.spaced(SAMPLE_INTERVAL))resolveKindfalls back to'auto'Macroscope summarized 4419ba0.