Skip to content

[codex] Revert Blacksmith workflow runners#2882

Closed
Bl4ckBl1zZ wants to merge 1 commit into
pingdotgg:mainfrom
Bl4ckBl1zZ:codex/revert-blacksmith-runners
Closed

[codex] Revert Blacksmith workflow runners#2882
Bl4ckBl1zZ wants to merge 1 commit into
pingdotgg:mainfrom
Bl4ckBl1zZ:codex/revert-blacksmith-runners

Conversation

@Bl4ckBl1zZ

@Bl4ckBl1zZ Bl4ckBl1zZ commented May 30, 2026

Copy link
Copy Markdown

Summary

  • replace Blacksmith runner labels with GitHub-hosted runners in CI and release workflows
  • restore the Windows arm64 release build and updater manifest merge path that the Blacksmith release experiment disabled
  • remove the remaining Blacksmith comments from release workflow runner config

Validation

  • bun fmt
  • bun lint (passes with existing unrelated warnings)
  • bun typecheck
  • git diff --check
  • Ruby YAML parse for .github/workflows/*.yml

Note

Medium Risk
Touches the full release pipeline (multi-OS builds, updater YAML merge, and publish gates); misconfiguration could break releases or auto-update metadata for Windows.

Overview
Reverts CI and release workflows from Blacksmith runner labels to GitHub-hosted runners (ubuntu-24.04, macos-14 / macos-15-intel, windows-2022, windows-11-arm, etc.) across quality, mobile native checks, release smoke, preflight, desktop builds, publish, deploy, finalize, and Discord announce jobs.

On the release path, it turns the Windows arm64 desktop build back on in the build matrix and restores the per-arch Windows updater manifest renaming during artifact collection plus the Merge Windows updater manifests step before publishing the GitHub release (logic that had been commented out during the Blacksmith experiment).

Reviewed by Cursor Bugbot for commit e02b31f. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Revert CI/release workflow runners from Blacksmith to GitHub-hosted runners

  • Replaces all Blacksmith runners in ci.yml and release.yml with standard GitHub-hosted runners (ubuntu-24.04, macos-14/15, windows-2022).
  • Adds a Windows arm64 build target (windows-11-arm) to the release matrix and enables per-arch Windows updater manifest renaming.
  • The release job now merges Windows x64 and arm64 updater manifests into a single channel manifest, failing if the arm64 manifest is missing.
📊 Macroscope summarized e02b31f. 2 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd3aa22e-dabc-475d-9d69-033fa29dd99c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels May 30, 2026
@Bl4ckBl1zZ Bl4ckBl1zZ closed this May 30, 2026
@Bl4ckBl1zZ Bl4ckBl1zZ deleted the codex/revert-blacksmith-runners branch May 30, 2026 21:57
@Bl4ckBl1zZ Bl4ckBl1zZ restored the codex/revert-blacksmith-runners branch May 30, 2026 21:58

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium

if: matrix.platform == 'win'

The 'Install Spectre-mitigated MSVC libs' step installs Microsoft.VisualStudio.Component.VC.Tools.x86.x64.Spectre for all Windows builds, including the new arm64 runner. This component only provides x86/x64 Spectre-mitigated libraries, not ARM64 variants. The arm64 build will either fail to compile or produce binaries without Spectre mitigation because the wrong component is installed.

🤖 Copy this AI Prompt to have your agent fix this:
In file .github/workflows/release.yml around line 239:

The 'Install Spectre-mitigated MSVC libs' step installs `Microsoft.VisualStudio.Component.VC.Tools.x86.x64.Spectre` for all Windows builds, including the new arm64 runner. This component only provides x86/x64 Spectre-mitigated libraries, not ARM64 variants. The arm64 build will either fail to compile or produce binaries without Spectre mitigation because the wrong component is installed.

@macroscopeapp

macroscopeapp Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

1 blocking correctness issue found. This PR enables Windows arm64 builds alongside the runner revert, and an unresolved comment identifies that the Spectre-mitigated MSVC libs step may not work correctly for arm64 builds. This potential build/security issue should be addressed before merging.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant