[codex] Revert Blacksmith workflow runners#2882
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Medium
t3code/.github/workflows/release.yml
Line 239 in e02b31f
The 'Install Spectre-mitigated MSVC libs' step installs Microsoft.VisualStudio.Component.VC.Tools.x86.x64.Spectre for all Windows builds, including the new arm64 runner. This component only provides x86/x64 Spectre-mitigated libraries, not ARM64 variants. The arm64 build will either fail to compile or produce binaries without Spectre mitigation because the wrong component is installed.
🤖 Copy this AI Prompt to have your agent fix this:
In file .github/workflows/release.yml around line 239:
The 'Install Spectre-mitigated MSVC libs' step installs `Microsoft.VisualStudio.Component.VC.Tools.x86.x64.Spectre` for all Windows builds, including the new arm64 runner. This component only provides x86/x64 Spectre-mitigated libraries, not ARM64 variants. The arm64 build will either fail to compile or produce binaries without Spectre mitigation because the wrong component is installed.
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. This PR enables Windows arm64 builds alongside the runner revert, and an unresolved comment identifies that the Spectre-mitigated MSVC libs step may not work correctly for arm64 builds. This potential build/security issue should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |
Summary
Validation
Note
Medium Risk
Touches the full release pipeline (multi-OS builds, updater YAML merge, and publish gates); misconfiguration could break releases or auto-update metadata for Windows.
Overview
Reverts CI and release workflows from Blacksmith runner labels to GitHub-hosted runners (
ubuntu-24.04,macos-14/macos-15-intel,windows-2022,windows-11-arm, etc.) across quality, mobile native checks, release smoke, preflight, desktop builds, publish, deploy, finalize, and Discord announce jobs.On the release path, it turns the Windows arm64 desktop build back on in the build matrix and restores the per-arch Windows updater manifest renaming during artifact collection plus the Merge Windows updater manifests step before publishing the GitHub release (logic that had been commented out during the Blacksmith experiment).
Reviewed by Cursor Bugbot for commit e02b31f. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Revert CI/release workflow runners from Blacksmith to GitHub-hosted runners
ubuntu-24.04,macos-14/15,windows-2022).windows-11-arm) to the release matrix and enables per-arch Windows updater manifest renaming.📊 Macroscope summarized e02b31f. 2 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.