Skip to content

Fix nitro import#76

Merged
pinpong merged 1 commit intopinpong:devfrom
iaudouard:fix-nitro-import
Nov 10, 2025
Merged

Fix nitro import#76
pinpong merged 1 commit intopinpong:devfrom
iaudouard:fix-nitro-import

Conversation

@iaudouard
Copy link
Copy Markdown
Contributor

Pull request

Please ensure this PR targets the dev branch and follows the project conventions.
CI already runs linting, formatting, and build checks automatically.


Before submitting

  • This PR targets the dev branch (not main)
  • Commit messages follow the semantic-release format
  • No debug logs or sensitive data included

Summary

Adds NitroModules import to ios/GoogleMapViewImpl.swift and ios/RNGoogleMapsPlusModule.swift.


Type of change

  • Feature
  • Fix
  • Refactor
  • Internal / CI
  • Documentation

Scope

  • Android
  • iOS
  • Core
  • Example App
  • Docs

Related


Additional notes

iOS build with Expo v54.0.22 was failing before the change.

❌  (node_modules/react-native-google-maps-plus/ios/GoogleMapViewImpl.swift:408:8)

  407 |     resultIsFile: Bool
> 408 |   ) -> NitroModules.Promise<String?> {
      |        ^ cannot find type 'NitroModules' in scope
  409 |     let promise = Promise<String?>()
  410 |
  411 |     onMainAsync {


❌  (node_modules/react-native-google-maps-plus/ios/GoogleMapViewImpl.swift:409:19)

  407 |     resultIsFile: Bool
  408 |   ) -> NitroModules.Promise<String?> {
  408 |   ) -> NitroModules.Promise<String?> {
> 409 |     let promise = Promise<String?>()
      |                   ^ cannot find 'Promise' in scope
  410 |
  411 |     onMainAsync {
  412 |       guard let mapView = self.mapView else {


❌  (node_modules/react-native-google-maps-plus/ios/GoogleMapViewImpl.swift:413:37)

  411 |     onMainAsync {
  412 |       guard let mapView = self.mapView else {
> 413 |         promise.resolve(withResult: nil)
      |                                     ^ 'nil' requires a contextual type
  414 |         return
  415 |       }
  416 |

@iaudouard iaudouard changed the base branch from main to dev November 9, 2025 17:24
@pinpong
Copy link
Copy Markdown
Owner

pinpong commented Nov 9, 2025

Thanks for the PR.
Which nitro-modules version are you working with because the ci pipeline compiles both platforms.

@iaudouard
Copy link
Copy Markdown
Contributor Author

Hi, thanks for the prompt reply. I am using v0.31.4.

@pinpong pinpong merged commit a432a0d into pinpong:dev Nov 10, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.8.8-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants