cleanup

Author: FionaBronwen

packages/graphql/src/lib/scalar-mappings.ts

@@ -15,7 +15,6 @@ export interface ScalarMapping {
 
 /**
  * Mapping table for TypeSpec standard library scalars to GraphQL custom scalars.
- * Based on design doc: https://github.com/microsoft/typespec/issues/4933
  */
 const SCALAR_MAPPINGS: Record<string, Record<string, ScalarMapping>> = {
   // int64 → BigInt (String)
@@ -48,7 +47,7 @@ const SCALAR_MAPPINGS: Record<string, Record<string, ScalarMapping>> = {
     },
   },
 
-  // bytes with different encodings
+  // bytes — requires @encode to determine format; without encoding, no GraphQL mapping applies
   bytes: {
     base64: {
       graphqlName: "Bytes",
@@ -62,7 +61,7 @@ const SCALAR_MAPPINGS: Record<string, Record<string, ScalarMapping>> = {
     },
   },
 
-  // utcDateTime with different encodings
+  // utcDateTime — requires @encode to determine wire format; no default mapping without encoding
   utcDateTime: {
     rfc3339: {
       graphqlName: "UTCDateTime",
@@ -80,7 +79,7 @@ const SCALAR_MAPPINGS: Record<string, Record<string, ScalarMapping>> = {
     },
   },
 
-  // offsetDateTime with different encodings
+  // offsetDateTime — requires @encode to determine wire format; no default mapping without encoding
   offsetDateTime: {
     rfc3339: {
       graphqlName: "OffsetDateTime",
@@ -106,7 +105,7 @@ const SCALAR_MAPPINGS: Record<string, Record<string, ScalarMapping>> = {
     },
   },
 
-  // duration with different encodings
+  // duration — requires @encode to determine wire format; no default mapping without encoding
   duration: {
     ISO8601: {
       graphqlName: "Duration",

packages/graphql/src/mutation-engine/engine.ts

@@ -1,7 +1,6 @@
 import {
   type Enum,
   type Model,
-  type Namespace,
   type Operation,
   type Program,
   type Scalar,
@@ -59,7 +58,7 @@ export class GraphQLMutationEngine {
    */
   private engine;
 
-  constructor(program: Program, _namespace: Namespace) {
+  constructor(program: Program) {
     const tk = $(program);
     this.engine = new MutationEngine(tk, graphqlMutationRegistry);
   }
@@ -101,11 +100,8 @@ export class GraphQLMutationEngine {
 }
 
 /**
- * Creates a GraphQL mutation engine for the given program and namespace.
+ * Creates a GraphQL mutation engine for the given program.
  */
-export function createGraphQLMutationEngine(
-  program: Program,
-  namespace: Namespace,
-): GraphQLMutationEngine {
-  return new GraphQLMutationEngine(program, namespace);
+export function createGraphQLMutationEngine(program: Program): GraphQLMutationEngine {
+  return new GraphQLMutationEngine(program);
 }

packages/graphql/src/mutation-engine/index.ts

@@ -6,4 +6,5 @@ export {
   GraphQLModelPropertyMutation,
   GraphQLOperationMutation,
   GraphQLScalarMutation,
+  GraphQLUnionMutation,
 } from "./mutations/index.js";

packages/graphql/test/mutation-engine/graphql-mutation-engine.test.ts

@@ -4,13 +4,8 @@ import { beforeEach, describe, expect, it } from "vitest";
 import { createGraphQLMutationEngine } from "../../src/mutation-engine/index.js";
 import { Tester } from "../test-host.js";
 
-/**
- * Helper to create the engine with the global namespace.
- * For unit tests, we use the global namespace since individual types
- * aren't placed in a custom namespace.
- */
 function createTestEngine(program: Parameters<typeof createGraphQLMutationEngine>[0]) {
-  return createGraphQLMutationEngine(program, program.getGlobalNamespaceType());
+  return createGraphQLMutationEngine(program);
 }
 
 describe("GraphQL Mutation Engine - Enums", () => {