Fix: Providing the motivation and how to use this guide#230
Fix: Providing the motivation and how to use this guide#230obsofficer-ctrl wants to merge 1 commit intopiotrwitek:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to improve the README by adding a 'Motivation' and 'How to Use This Guide' section. While the new content is well-written and a good addition for new users, the current implementation has a critical flaw: it replaces the entire existing README_SOURCE.md (which was 1051 lines) with just these new introductory sections (57 lines). This results in the deletion of the vast majority of the guide's valuable content, including the table of contents, installation instructions, code examples, and detailed explanations. This is almost certainly not the intended outcome. The new sections should be integrated into the existing README, likely at the beginning, rather than replacing the whole file. I've also pointed out a few other issues in the new content, such as outdated version information.
| [⇧ back to top](#table-of-contents) | ||
| [](https://github.com/piotrwitek/react-redux-typescript-guide/stargazers) | ||
|
|
||
| :tada: _Now updated to support **TypeScript v3.7**, **React v16.9** and **Redux v4.x**_ :tada: |
There was a problem hiding this comment.
| 1. **React** — How to type functional components, class components, hooks, events, refs, context, and more. All the type annotations (like `React.FC<Props>`, `React.ChangeEvent<HTMLInputElement>`) come from the `@types/react` package and are explained here with practical examples. | ||
|
|
||
| ```ts | ||
| { | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "redux": ["typings/redux"], // use an alternative type-definitions instead of the included one | ||
| ... | ||
| }, | ||
| ..., | ||
| } | ||
| } | ||
| ``` | ||
| 2. **Redux** — How to type actions, reducers, and the store in a Redux application. | ||
|
|
||
| [⇧ back to top](#table-of-contents) | ||
| 3. **Recipes** — Common patterns and solutions to problems you'll encounter day-to-day. |
There was a problem hiding this comment.
This is a helpful overview. To improve navigation, consider making the section titles into internal links that jump to the corresponding parts of the document. The previous version of the guide had anchors for React and Redux.
For example:
1. [**React**](#react) — ...
2. [**Redux**](#redux) — ...Also, the 'Recipes' section seems to be a new concept. If you plan to restructure the document, ensure an anchor for it exists.
| ### Try It Yourself | ||
|
|
||
| MIT License | ||
| A **playground** is included in this repo under the [`/playground`](./playground) folder. It is a Create React App project with TypeScript preconfigured. You can clone this repo and run it locally to experiment with all the patterns shown in the guide: |
There was a problem hiding this comment.
This sentence ends with a colon, which usually implies that more information (like a code block with setup commands) is about to follow. If this is the end of the section, the colon should probably be replaced with a period for correct punctuation.
| A **playground** is included in this repo under the [`/playground`](./playground) folder. It is a Create React App project with TypeScript preconfigured. You can clone this repo and run it locally to experiment with all the patterns shown in the guide: | |
| A **playground** is included in this repo under the [`/playground`](./playground) folder. It is a Create React App project with TypeScript preconfigured. You can clone this repo and run it locally to experiment with all the patterns shown in the guide. |
Summary
This PR addresses: #82
Task: Providing the motivation and how to use this guide
Platform: github
Changes
Looking at this issue, the request is to improve the README to provide better onboarding experience, especially for beginners. I need to update
README_SOURCE.mdto add a better introduction/motivation section and a "How to Use This Guide" section.Since I don't have the full
README_SOURCE.mdcontent, I'll create an improved introduction section that addresses the issue's concerns. Let me analyze what's needed: