Skip to content

Add typed forwardRef example with Input component #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
The-Spik3r wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add typed forwardRef example with Input component #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions path/to/ForwardedInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import React, { forwardRef, Ref, InputHTMLAttributes } from 'react';

type ForwardedInputProps = InputHTMLAttributes<HTMLInputElement>;

const ForwardedInput = forwardRef<HTMLInputElement, ForwardedInputProps>(
(props, ref: Ref<HTMLInputElement>) => {
return <input ref={ref} {...props} />;
}
Comment on lines +6 to +8
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The explicit type annotation ref: Ref<HTMLInputElement> is redundant and not entirely correct. The ref parameter's type is ForwardedRef<HTMLInputElement>, which is subtly different from Ref. It's best practice to let TypeScript infer this type from forwardRef. This also allows for a more concise implementation.

After applying this change, you can remove the Ref import from line 1 as it will no longer be used.

  (props, ref) => <input ref={ref} {...props} />

);
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve debuggability with React DevTools, it's a good practice to add a displayName to components created with forwardRef.

);

ForwardedInput.displayName = 'ForwardedInput';


export default ForwardedInput;