Skip to content

docs: add typed Recompose HOC examples#318

Open
Danservfinn wants to merge 2 commits into
piotrwitek:masterfrom
Danservfinn:kublai/recompose-examples
Open

docs: add typed Recompose HOC examples#318
Danservfinn wants to merge 2 commits into
piotrwitek:masterfrom
Danservfinn:kublai/recompose-examples

Conversation

@Danservfinn

Copy link
Copy Markdown

Summary

  • Adds a source-backed Recompose withStateHandlers example to the HOC section.
  • Shows the TypeScript pattern for separating wrapped component props from injected enhancer props.
  • Includes the generated README update and playground dependency declarations for recompose / @types/recompose.

Validation

  • cd playground && npm run tsc
  • cd playground && npm run lint
  • npm run ci-check
  • git diff --check

Closes #46


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new example demonstrating the use of Recompose's withStateHandlers HOC with TypeScript, including documentation updates in the README files and implementation in the playground. The feedback suggests pinning the newly added recompose and @types/recompose dependencies to exact versions in package.json to maintain consistency with the rest of the project.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread playground/package.json Outdated
"@types/react-dom": "18.0.3",
"@types/react-redux": "7.1.24",
"@types/react-router-dom": "5.3.3",
"@types/recompose": "^0.30.15",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with all other dependencies in this project, please pin @types/recompose to an exact version instead of using a caret range (^).

Suggested change
"@types/recompose": "^0.30.15",
"@types/recompose": "0.30.15",

Comment thread playground/package.json Outdated
"react-redux": "7.2.8",
"react-router-dom": "6.3.0",
"react-scripts": "5.0.1",
"recompose": "^0.30.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with all other dependencies in this project, please pin recompose to an exact version instead of using a caret range (^).

Suggested change
"recompose": "^0.30.0",
"recompose": "0.30.0",

@Danservfinn

Copy link
Copy Markdown
Author

Updated to address the dependency-version review note: pinned recompose to 0.30.0 and @types/recompose to 0.30.15 to match the repo's existing exact-version style. Re-ran validation: cd playground && npm run tsc, cd playground && npm run lint, npm run ci-check, and git diff --check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

suggestion: recompose examples

1 participant