fix: MCP stdio transport and add tool descriptions#56
Open
skmahe1077 wants to merge 3 commits intopipe-cd:mainfrom
Open
fix: MCP stdio transport and add tool descriptions#56skmahe1077 wants to merge 3 commits intopipe-cd:mainfrom
skmahe1077 wants to merge 3 commits intopipe-cd:mainfrom
Conversation
Signed-off-by: Mahendran Selvakumar <skmahe1077@gmail.com>
* Fix Cursor deeplink URL returning 404 error Signed-off-by: Mahendran Selvakumar <skmahe1077@gmail.com> * Fix Cursor deeplink to use HTML anchor tag for GitHub compatibility Signed-off-by: Mahendran Selvakumar <skmahe1077@gmail.com> * Fix Cursor deeplink to use correct install URL Signed-off-by: Mahendran Selvakumar <skmahe1077@gmail.com> --------- Signed-off-by: Mahendran Selvakumar <skmahe1077@gmail.com>
Signed-off-by: Mahendran Selvakumar <skmahe1077@gmail.com>
skmahe1077
force-pushed
the
fix/console-info-stdout-55
branch
from
253fc7b to
260213f
Compare
khanhtc1202
reviewed
Apr 10, 2026
|
|
||
| try { | ||
| console.info(`Start cloning repo ${REPO} to ${targetDir}`); | ||
| console.error(`Start cloning repo ${REPO} to ${targetDir}`); |
Member
There was a problem hiding this comment.
Why should we use error over info here?
Contributor
Author
There was a problem hiding this comment.
In a normal Node app console.info is fine. But MCP servers communicate over stdio, the client reads stdout expecting only valid JSON. Any non-JSON text (like "Successfully cloned...") breaks the protocol.console.error here doesn't mean something went wrong, it just routes the message to stderr, which MCP clients ignore (or display in debug logs)
eeshaanSA
reviewed
Apr 10, 2026
eeshaanSA
left a comment
eeshaanSA
left a comment
There was a problem hiding this comment.
Looks good. I am just not sure about console.error, I will check once on this. Your reply looks solid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the developer experience and API usability for the PipeCD docs tools by adding helpful descriptions to the API methods and making minor logging adjustments. The key changes are grouped below:
API usability improvements:
search_docstool, clarifying that it performs a full-text AND search over PipeCD docs using space-separated keywords.read_docstool by providing a clear description of its purpose and usage, specifying that it returns the full content of a specified doc page and how to provide the path.Logging changes:
console.infotoconsole.errorinsrc/loader.tsfor both the start and successful completion of the repository cloning process. [1] [2]After modified MCP Server working fine locally and we need to create the new release