Skip to content

Commit 2892490

Browse files
committed
bump some tools
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
1 parent 69f7923 commit 2892490

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/lint.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ on:
77
pull_request:
88
branches:
99
- master
10-
- 'release-v*'
11-
- 'feat/*'
10+
- "release-v*"
11+
- "feat/*"
1212

1313
env:
1414
GO_VERSION: 1.24.1
1515
NODE_VERSION: 18.12.0
16-
GOLANGCI_LINT_VERSION: v1.64.7
16+
GOLANGCI_LINT_VERSION: v2.4.0
1717
HELM_VERSION: 3.17.3
1818

1919
jobs:
@@ -38,13 +38,13 @@ jobs:
3838
steps:
3939
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
4040
- name: golangci-lint
41-
uses: reviewdog/action-golangci-lint@f3dc5fadcaff5d8da3574b129a58db433171b1a8 #v2.1.3
41+
uses: reviewdog/action-golangci-lint@f9bba13753278f6a73b27a56a3ffb1bfda90ed71 #v2.8.0
4242
with:
4343
workdir: ${{ matrix.module }}
4444
go_version: ${{ env.GO_VERSION }}
4545
golangci_lint_version: ${{ env.GOLANGCI_LINT_VERSION }}
4646
golangci_lint_flags: --config ${{ github.workspace }}/.golangci.yml
47-
fail_on_error: true # this option is deprecated on v2.7.0, but we use v2.1.3, so it's still available
47+
fail_level: error
4848

4949
# This job is used to check if the go linting is completed successfully
5050
# It is used to set as required check for the branch protection rules

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ lint: lint/go lint/web lint/helm
206206

207207
.PHONY: lint/go
208208
lint/go: FIX ?= false
209-
lint/go: VERSION ?= sha256:c2f5e6aaa7f89e7ab49f6bd45d8ce4ee5a030b132a5fbcac68b7959914a5a890 # golangci/golangci-lint:v1.64.7
209+
lint/go: VERSION ?= sha256:91460846c43b3de53eb77e968b17363e8747e6f3fc190575b52be60c49446e23 # golangci/golangci-lint:v2.4.0
210210
lint/go: FLAGS ?= --rm -e GOCACHE=/repo/.cache/go-build -e GOLANGCI_LINT_CACHE=/repo/.cache/golangci-lint -v ${PWD}:/repo -it
211211
lint/go: MODULES ?= $(shell find . -name go.mod | while read -r dir; do dirname "$$dir"; done | paste -sd, -) # comma separated list of modules. eg: MODULES=.,pkg/plugin/sdk
212212
lint/go:

0 commit comments

Comments
 (0)