Skip to content

Commit a5ca9ec

Browse files
Merge branch 'master' into docs/move-plugins-v1
2 parents ba7bb5c + 1765e94 commit a5ca9ec

15 files changed

Lines changed: 465 additions & 266 deletions

File tree

pkg/app/piped/platformprovider/ecs/task.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,18 @@ func FindImageTag(taskDefinition types.TaskDefinition) (string, error) {
5454
}
5555

5656
func parseContainerImage(image string) (name, tag string) {
57-
parts := strings.Split(image, ":")
58-
if len(parts) == 2 {
59-
tag = parts[1]
57+
paths := strings.Split(image, "/")
58+
lastSegment := paths[len(paths)-1]
59+
60+
idx := strings.LastIndex(lastSegment, ":")
61+
if idx == -1 {
62+
name = lastSegment
63+
tag = ""
64+
return
6065
}
61-
paths := strings.Split(parts[0], "/")
62-
name = paths[len(paths)-1]
66+
67+
name = lastSegment[:idx]
68+
tag = lastSegment[idx+1:]
6369
return
6470
}
6571

pkg/app/piped/platformprovider/ecs/task_test.go

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,42 @@ func TestFindArtifactVersions(t *testing.T) {
9292
expected []*model.ArtifactVersion
9393
expectedErr bool
9494
}{
95+
{
96+
name: "image with registry port",
97+
input: []byte(`
98+
{
99+
"family": "nginx-canary-fam-1",
100+
"compatibilities": [
101+
"FARGATE"
102+
],
103+
"networkMode": "awsvpc",
104+
"memory": 512,
105+
"cpu": 256,
106+
"containerDefinitions" : [
107+
{
108+
"image": "localhost:5000/pipecd/helloworld:v1.0.0",
109+
"name": "helloworld",
110+
"portMappings": [
111+
{
112+
"containerPort": 80,
113+
"hostPort": 9085,
114+
"protocol": "tcp"
115+
}
116+
]
117+
}
118+
]
119+
}
120+
`),
121+
expected: []*model.ArtifactVersion{
122+
{
123+
Kind: model.ArtifactVersion_CONTAINER_IMAGE,
124+
Version: "v1.0.0",
125+
Name: "helloworld",
126+
Url: "localhost:5000/pipecd/helloworld:v1.0.0",
127+
},
128+
},
129+
expectedErr: false,
130+
},
95131
{
96132
name: "ok",
97133
input: []byte(`

pkg/app/pipedv1/plugin/analysis/go.mod

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,23 @@ require (
88
github.com/pipe-cd/piped-plugin-sdk-go v0.1.0
99
github.com/prometheus/client_golang v1.12.1
1010
github.com/prometheus/common v0.32.1
11-
github.com/stretchr/testify v1.10.0
11+
github.com/stretchr/testify v1.11.1
1212
go.uber.org/zap v1.19.1
13-
golang.org/x/sync v0.18.0
13+
golang.org/x/sync v0.19.0
1414
sigs.k8s.io/yaml v1.5.0
1515
)
1616

1717
require (
1818
cloud.google.com/go v0.112.1 // indirect
19-
cloud.google.com/go/compute/metadata v0.3.0 // indirect
19+
cloud.google.com/go/compute/metadata v0.9.0 // indirect
2020
cloud.google.com/go/profiler v0.3.1 // indirect
2121
github.com/beorn7/perks v1.0.1 // indirect
22-
github.com/cespare/xxhash/v2 v2.2.0 // indirect
22+
github.com/cespare/xxhash/v2 v2.3.0 // indirect
2323
github.com/coreos/go-oidc/v3 v3.11.0 // indirect
2424
github.com/davecgh/go-spew v1.1.1 // indirect
25-
github.com/envoyproxy/protoc-gen-validate v1.0.4 // indirect
26-
github.com/go-jose/go-jose/v4 v4.0.5 // indirect
27-
github.com/go-logr/logr v1.4.2 // indirect
25+
github.com/envoyproxy/protoc-gen-validate v1.3.0 // indirect
26+
github.com/go-jose/go-jose/v4 v4.1.3 // indirect
27+
github.com/go-logr/logr v1.4.3 // indirect
2828
github.com/go-logr/stdr v1.2.2 // indirect
2929
github.com/golang-jwt/jwt/v5 v5.2.2 // indirect
3030
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
@@ -48,25 +48,26 @@ require (
4848
github.com/spf13/cobra v1.9.1 // indirect
4949
github.com/spf13/pflag v1.0.6 // indirect
5050
go.opencensus.io v0.24.0 // indirect
51+
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
5152
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.49.0 // indirect
52-
go.opentelemetry.io/otel v1.28.0 // indirect
53-
go.opentelemetry.io/otel/metric v1.28.0 // indirect
54-
go.opentelemetry.io/otel/trace v1.28.0 // indirect
53+
go.opentelemetry.io/otel v1.39.0 // indirect
54+
go.opentelemetry.io/otel/metric v1.39.0 // indirect
55+
go.opentelemetry.io/otel/trace v1.39.0 // indirect
5556
go.uber.org/atomic v1.11.0 // indirect
5657
go.uber.org/multierr v1.6.0 // indirect
5758
go.yaml.in/yaml/v2 v2.4.2 // indirect
58-
golang.org/x/crypto v0.45.0 // indirect
59-
golang.org/x/net v0.47.0 // indirect
60-
golang.org/x/oauth2 v0.30.0 // indirect
61-
golang.org/x/sys v0.38.0 // indirect
62-
golang.org/x/text v0.31.0 // indirect
59+
golang.org/x/crypto v0.46.0 // indirect
60+
golang.org/x/net v0.48.0 // indirect
61+
golang.org/x/oauth2 v0.34.0 // indirect
62+
golang.org/x/sys v0.39.0 // indirect
63+
golang.org/x/text v0.32.0 // indirect
6364
golang.org/x/time v0.5.0 // indirect
6465
google.golang.org/api v0.169.0 // indirect
6566
google.golang.org/genproto v0.0.0-20240213162025-012b6fc9bca9 // indirect
66-
google.golang.org/genproto/googleapis/api v0.0.0-20240701130421-f6361c86f094 // indirect
67-
google.golang.org/genproto/googleapis/rpc v0.0.0-20240701130421-f6361c86f094 // indirect
68-
google.golang.org/grpc v1.64.1 // indirect
69-
google.golang.org/protobuf v1.34.2 // indirect
67+
google.golang.org/genproto/googleapis/api v0.0.0-20251202230838-ff82c1b0f217 // indirect
68+
google.golang.org/genproto/googleapis/rpc v0.0.0-20251202230838-ff82c1b0f217 // indirect
69+
google.golang.org/grpc v1.79.3 // indirect
70+
google.golang.org/protobuf v1.36.10 // indirect
7071
gopkg.in/yaml.v2 v2.4.0 // indirect
7172
gopkg.in/yaml.v3 v3.0.1 // indirect
7273
)

0 commit comments

Comments
 (0)