[CI] Add dependabot and govulncheck checks#6435
[CI] Add dependabot and govulncheck checks#6435mohammedfirdouss wants to merge 3 commits intopipe-cd:masterfrom
Conversation
c15d4e1 to
148b5a3
Compare
Ayushmore1214
left a comment
There was a problem hiding this comment.
Adding go module caching would be better for faster CI runs WDYT @mohammedfirdouss ?
Hmm, I think this is a good idea. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6435 +/- ##
===========================================
+ Coverage 29.47% 53.96% +24.49%
===========================================
Files 584 7 -577
Lines 62474 315 -62159
===========================================
- Hits 18414 170 -18244
+ Misses 42636 129 -42507
+ Partials 1424 16 -1408 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@khanhtc1202 Merge conflict has been resolved. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@mohammedfirdouss But I have a concern. @khanhtc1202 please comment if you have another idea. |
Hi @Warashi, thank you for catching this! You're absolutely right. Let me investigate the govulncheck failures immediately. My plan:
I'll have findings + plan by end of day and will either push fixes or create the tracking issue shortly. @khanhtc1202 - thoughts on preferred approach? |
|
Created tracking issue #6600. The govulncheck failures are pre-existing vulnerabilities, this PR correctly surfaces them. I'll work on fixing them in a separate PR so we can unblock this one without breaking master. The scan still runs and reports vulnerabilities, but won't block the PR from merging. Once the vulnerabilities are fixed (tracked in #6600), we can make it blocking again. Ready for re-review @Warashi @khanhtc1202 Also, i saw that i will have to update the Go version, so that would probably be a huge bump since it will affect other yml files like test etc. please check the tracking issue for more info CI Run: https://github.com/pipe-cd/pipecd/actions/runs/23225979807 |
|
@mohammedfirdouss |
Sure no problem. I will look into this @Warashi |
|
@mohammedfirdouss please resolve the conflict, so that we can process to merge this PR, thanks 👍 |
f9f0bf1 to
f9b0930
Compare
c03eabd to
abfca05
Compare
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
abfca05 to
20eab53
Compare
What this PR does:
Adds automated dependency and vulnerability checks to CI by introducing Dependabot configuration and integrating
govulncheckinto the lint workflow.This PR configures Dependabot to monitor Go and npm dependencies across key directories, and extends lint CI to run
govulncheckfor Go modules via matrix jobs. It also keeps a completion-job pattern for branch protection compatibility.Why we need it:
Without continuous dependency and vulnerability checks, security updates can be delayed and known Go vulnerabilities may go unnoticed until later stages.
Which issue(s) this PR fixes:
Refs #6409
Does this PR introduce a user-facing change?:
Validation:
.github/dependabot.yml.govulncheckworkflow wiring and matrix execution logic in.github/workflows/lint.yaml.