Skip to content

handle plugins#129

Open
sivchari wants to merge 1 commit intopipe-cd:mainfrom
sivchari:handle-plugins
Open

handle plugins#129
sivchari wants to merge 1 commit intopipe-cd:mainfrom
sivchari:handle-plugins

Conversation

@sivchari
Copy link
Copy Markdown
Member

Handle plugins field for next features.

@sivchari
Copy link
Copy Markdown
Member Author

Hi @kurochan @arabian9ts @pipe-cd/maintainers ,PTAL

@sivchari sivchari force-pushed the handle-plugins branch 8 times, most recently from d0e7e90 to 0e89dd3 Compare April 23, 2025 18:23
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@arabian9ts
Copy link
Copy Markdown
Member

@sivchari Thank you for this PR and sorry for the delay in reviewing.
I'll list a few concerns about the impl, which includes modifications to pipecd as well:

  1. Please update the example to use plugins.
  2. When calling the AddApplication RPC, it would be preferred that deploy_targets field is saved atomically. It would be better to modify pipecd's AddApplication impl.
  3. Even if you specify values in deploy_targets that are not included in piped's config, it doesn't result in any error. Some salidations are needed in pipecd.

@khanhtc1202
regarding points 2 and 3, if my understanding is correct, I'll submit issues in pipecd - what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants