Fix parallel node functions triggering multiple LLM completions#244
Open
omChauhanDev wants to merge 2 commits into
Open
Fix parallel node functions triggering multiple LLM completions#244omChauhanDev wants to merge 2 commits into
omChauhanDev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #243, pipecat-ai/pipecat#3925
When the LLM makes multiple parallel calls to the same node function (common with
global_functions), each result was triggering a separate LLM completion — producing multiple responses instead of one.Root cause: node functions explicitly set
run_llm=Trueon each result, overriding pipecat's built-in logic that already knows to wait until all parallel calls finish.Fix:
run_llm=True→run_llm=None- let pipecat's default handle it.