Fixed SimliVideoService pushing near-silent audio constantly preventing BotStoppedSpeaking #4076
Open
phamtrung0633 wants to merge 3 commits into
Open
Fixed SimliVideoService pushing near-silent audio constantly preventing BotStoppedSpeaking #4076phamtrung0633 wants to merge 3 commits into
phamtrung0633 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
|
If I run example 27 using Whisker to inspect frames, I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Fixed SimliVideoService forwarding near-silent audio frames (quantization noise) as TTSAudioRawFrame. Added RMS threshold check to skip frames below 1.0, which is well above the observed noise floor (~0.41) but far below real speech. Without this fix - BotStoppedSpeaking will never trigger.