Keeping audio and clock queue in sync.#4178
Closed
filipi87 wants to merge 4 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
I tested all TTS services that provide word timestamps:
Only Rime is returning incorrect timestamps. However, the fix in the PR is not specifically addressing the Rime issue. Instead, it acts as a safeguard to ensure both queues stay in sync by using the TTSStopped frame as a gatekeeper. But closing it for now, since Rime is currently the only service that would benefit from this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TTSStoppedFramecarries a presentation timestamp (pts), it is ow enqueued in both theaudio_queueand theclock_queueso that timed frames (e.g. word-boundary events) and audio playback stay in sync.TTSStoppedFrame, it signals the clock task via_clock_flush_eventto stop waiting on timestamps and drain all pending frames immediately._clock_drained_eventonce the drain is complete, so the audio task can pushTTSStoppedFramedownstream.BOT_VAD_STOP_FALLBACK_SECStimeout guards the wait on_clock_drained_eventto prevent a deadlock if the clock task fails before completing the drain.