fix(pipeline): stop proxy tasks before cleaning up observer resources#4200
Closed
1Ckpwee wants to merge 1 commit into
Closed
fix(pipeline): stop proxy tasks before cleaning up observer resources#42001Ckpwee wants to merge 1 commit into
1Ckpwee wants to merge 1 commit into
Conversation
Contributor
|
Thanks for identifying this issue, @khulnasoft-lab! The root cause analysis was spot on — proxy tasks were indeed still running when observer resources got cleaned up during shutdown. We've addressed this in #4267 with a slightly different approach: instead of having Closing this in favor of #4267. Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4195
During pipeline shutdown,
TaskObserver.cleanup()was closing observer resources (file handles, connections) before cancelling the asyncio proxy tasks that were still consuming frames from queues. Late-arriving frames would hit the already-closed resource, producingValueError: write to closed file.Two bugs compounded:
cleanup()— only cancelled later in thePipelineTask.run()finally blockself._proxiesis aDict[BaseObserver, Proxy], so iterating it yieldedBaseObserverkeys rather thanProxyvaluesChanges
await self.stop()at the start ofcleanup()to cancel proxy tasks before any resources are closedself._proxies.values()to correctly accessProxyobjectsTest plan
ValueError: write to closed filestop()called multiple times is safe (idempotent)