CICDL-378: Remove unused NPM_PUBLIC_PUBLISH_TOKEN#4
Open
ahmedabdullajev-pi wants to merge 4 commits into
Open
Conversation
…rkflow All public packages have migrated to OIDC Trusted Publishers (CICDL-258), making the token-based publish path dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Jun 15, 2026
Merged
OIDC is now the only publish path — the toggle is no longer needed. Removes the input from the wrapper (reusable_cicd-npm-publish.yml) and the inner workflow (reusable_cicd-npm-package-publish.yml). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ting Will revert before merging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Test passed — OIDC-only publish verified in test-public-npm-module#32. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After completing CICDL-258 (migrate npm publishing to OIDC Trusted Publishers), the
NPM_PUBLIC_PUBLISH_TOKENsecret anduse_trusted_publisherinput are no longer needed. This PR removes the token-based publish code path entirely, making OIDC the only publish method.All 4 public package repos have PRs to stop passing
use_trusted_publisher:pipedrive/create-pipedrive-app— CICDL-378: Remove unused use_trusted_publisher input pipedrive/create-pipedrive-app#24pipedrive/client-nodejs— CICDL-378: Remove unused use_trusted_publisher input pipedrive/client-nodejs#739pipedrive/app-extensions-sdk— CICDL-378: Remove unused use_trusted_publisher input pipedrive/app-extensions-sdk#72pipedrive/test-public-npm-module— CICDL-378: Remove use_trusted_publisher and pin to @master pipedrive/test-public-npm-module#31use_trusted_publisherinput before callers stop passing it would break their workflows.What's removed:
NPM_PUBLIC_PUBLISH_TOKENsecret inputuse_trusted_publisherinput (from both wrapper and inner workflow)NPM_TOKENenv var from the "Publish to NPM" stepuse_trusted_publisherin the wrapper workflowTested
Verified end-to-end in pipedrive/test-public-npm-module#32 — publish workflow pointed to this feature branch (both wrapper and inner workflow), with
use_trusted_publisherremoved from the caller.Result:
@pipedrive/test-public-npm-module@1.0.19published successfully via OIDC with signed provenance (run logs):NPM_PUBLIC_PUBLISH_TOKENused.npmrctoken auth createdValidate token configurationstep rannpm notice publish Signed provenance statement with source and build information from GitHub ActionsProvenance statement published to transparency log: https://search.sigstore.dev/?logIndex=1825288959Remaining cleanup (outside this repo)
Per CICDL-378:
NPM_PUBLIC_PUBLISH_TOKENfrom GitHub Actions org-level secretspipedrive-github-publish-bot