Merge pull request #37 from alex-bukach/36-no-params

Siim Kirjanen · web-flow · commit 88283db4f78f · 2021-05-21T10:52:25.000+03:00
Resolved #36: Added parameters check
diff --git a/src/APIHelper.php b/src/APIHelper.php
@@ -64,7 +64,10 @@ public static function appendUrlWithQueryParameters(&$queryBuilder, $parameters)
         if (is_null($queryBuilder) || !is_string($queryBuilder)) {
             throw new InvalidArgumentException('Given value for parameter "queryBuilder" is invalid.');
         }
-        if (is_null($parameters)) {
+        $parameters = array_filter($parameters, function($value) {
+            return isset($value);
+        });
+        if (empty($parameters)) {
             return;
         }
         //does the query string already has parameters

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,10 @@ public static function appendUrlWithQueryParameters(&$queryBuilder, $parameters)`
`64`	`64`	`if (is_null($queryBuilder) \|\| !is_string($queryBuilder)) {`
`65`	`65`	`throw new InvalidArgumentException('Given value for parameter "queryBuilder" is invalid.');`
`66`	`66`	`}`
`67`		`- if (is_null($parameters)) {`
	`67`	`+ $parameters = array_filter($parameters, function($value) {`
	`68`	`+ return isset($value);`
	`69`	`+ });`
	`70`	`+ if (empty($parameters)) {`
`68`	`71`	`return;`
`69`	`72`	`}`
`70`	`73`	`//does the query string already has parameters`