fix: improve parseFlags and dispatchSubcommand error handling

Author: dmitriyeff

src/cli.test.ts

@@ -46,9 +46,11 @@ afterEach(async () => {
 });
 
 describe('dispatchSubcommand', () => {
-	it('returns false for unknown subcommand', async () => {
+	it('throws for unknown subcommand', async () => {
 		const { dispatchSubcommand } = await import('./cli.js');
-		expect(await dispatchSubcommand(['node', 'cli.js', 'unknown'])).toBe(false);
+		await expect(dispatchSubcommand(['node', 'cli.js', 'unknown'])).rejects.toThrow(
+			'Unknown subcommand: "unknown"',
+		);
 	});
 
 	it('returns true and runs add-app-extension for matching subcommand', async () => {
@@ -109,6 +111,13 @@ describe('parseFlags', () => {
 		expect(parseFlags(['node', 'cli.js', '--app-extensions', 'none'])).toMatchObject({ appExtensions: [] });
 	});
 
+	it('throws when --app-extensions combines none with extension types', async () => {
+		const { parseFlags } = await import('./cli.js');
+		expect(() => parseFlags(['node', 'cli.js', '--app-extensions', 'none,custom-panel'])).toThrow(
+			'"none" cannot be combined with other extension types.',
+		);
+	});
+
 	it('parses --app-extensions custom-panel', async () => {
 		const { parseFlags } = await import('./cli.js');
 		expect(parseFlags(['node', 'cli.js', '--app-extensions', 'custom-panel'])).toMatchObject({
@@ -140,7 +149,16 @@ describe('parseFlags', () => {
 	it('parses all three flags together', async () => {
 		const { parseFlags } = await import('./cli.js');
 		expect(
-			parseFlags(['node', 'cli.js', '--project-name', 'my-app', '--database', 'sqlite', '--app-extensions', 'none']),
+			parseFlags([
+				'node',
+				'cli.js',
+				'--project-name',
+				'my-app',
+				'--database',
+				'sqlite',
+				'--app-extensions',
+				'none',
+			]),
 		).toEqual({ nameOrPath: 'my-app', database: 'sqlite', appExtensions: [] });
 	});
 });

src/cli.ts

@@ -83,6 +83,9 @@ export function parseFlags(argv: string[]): ParsedFlags {
 		if (value === 'none') {
 			result.appExtensions = [];
 		} else {
+			if (value.includes(',') && value.split(',').includes('none')) {
+				throw new Error('"none" cannot be combined with other extension types.');
+			}
 			const types = value.split(',');
 			for (const type of types) {
 				if (!isAppExtensionType(type)) {
@@ -104,12 +107,23 @@ export async function dispatchSubcommand(argv: string[]): Promise<boolean> {
 	if (subcommand === 'add-app-extension') {
 		const appExtIdx = argv.indexOf('--app-extensions');
 		const appExtValue = appExtIdx !== -1 ? argv[appExtIdx + 1] : undefined;
-		const appExtensions: AppExtensionType[] | undefined =
-			appExtValue !== undefined && isAppExtensionType(appExtValue) ? [appExtValue] : undefined;
+		let appExtensions: AppExtensionType[] | undefined;
+		if (appExtValue !== undefined) {
+			if (!isAppExtensionType(appExtValue)) {
+				throw new Error(
+					`Invalid app extension type "${appExtValue}". Choose from: custom-panel, custom-modal.`,
+				);
+			}
+			appExtensions = [appExtValue];
+		}
 		await addAppExtension(outputDir, appExtensions);
 		return true;
 	}
 
+	if (subcommand && !subcommand.startsWith('--')) {
+		throw new Error(`Unknown subcommand: "${subcommand}". Available: add-app-extension`);
+	}
+
 	return false;
 }