fix: smoke pre-merge — field condition actionId, search_pipes truncation, comment length UX#115
Merged
Merged
Conversation
Both GET_FIELD_CONDITION_QUERY and GET_FIELD_CONDITIONS_QUERY only selected
actions { phaseFieldId }, so callers could never see which action was saved.
Discovered while smoke-testing the 2026-05-15 architectural pass — verifying
the hidden->hide normalization required falling back to raw GraphQL.
Tests gain an `actionId in <query>.loc.source.body` assertion to guard
regression and the response fixtures now include `actionId: "hide"`.
…an pipesCount SEARCH_PIPES_QUERY now selects Organization.pipesCount; the unfiltered branch sets pipes_truncated when the visible list is shorter than that total or when sliced by max_pipes_per_org. Adds unit tests and query AST guard.
…ion errors Map Pydantic too_long/string_too_long on CommentInput.text to an explicit 1000-character limit message instead of the generic card_id/text hint.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionIdinGET_FIELD_CONDITION/GET_FIELD_CONDITIONSqueries so CLI/MCP surface saved condition actions.search_pipeswithout name filter now setspipes_truncatedwhen the API returns fewerpipesthan orgpipesCount(and still when sliced bymax_pipes_per_org);SEARCH_PIPES_QUERYselectspipesCount.add_card_commentmaps Pydantictoo_long/string_too_longontextto an explicit 1000-character limit message instead of the genericcard_id/ non-empty hint.Context and severity ordering:
.cursor/dev-planning/investigations/smoke-2026-05-15-pre-main-merge.md(MCP findings #1 and #2, plus Finding C1).Follow-ups (not in this PR)
Per smoke doc §6 / TL;DR: MCP #3–#12 and CLI C3–C5 remain deferred to separate tickets.
Test plan
uv run pytest -q— 2042 passed, 24 skippeduv run pytest -m "not integration" -q— 2024 passeduv run ruff check .&&uv run ruff format --check .ruffonpackages/*/src,uv build packages/mcp,sync_starter_pack --check,lint_skill_refs.py