Skip to content

Commit 020af15

Browse files
committed
Remove commented code. Ensure gogo is supplied in the pxapi wheel
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent b7f3782 commit 020af15

3 files changed

Lines changed: 1 addition & 12 deletions

File tree

bazel/proto_compile.bzl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@ def _colocate_python_files_impl(ctx):
172172
dest.path,
173173
)
174174
for src, dest in src_dest
175-
# ]) + "\n" + "\n".join([
176-
# "sed -i 's|from github.com|from github|g' {}".format(
177-
# dest.path,
178-
# )
179-
# for src, dest in src_dest
180175
]),
181176
)
182177
ctx.actions.run(

src/api/proto/cloudpb/BUILD.bazel

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,6 @@ pl_go_proto_library(
4242
],
4343
)
4444

45-
# pl_py_grpc_library(
46-
# name = "gogo_python_pl_py_grpc",
47-
# # imports = [""],
48-
# proto = "//third_party/gogo/protobuf/gogoproto:gogo_python_proto",
49-
# visibility = ["//src:__subpackages__"],
50-
# )
51-
5245
pl_py_grpc_library(
5346
name = "cloudapi_pl_py_grpc",
5447
imports = ["../../../../"],

src/api/python/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ py_wheel(
4949
deps = [
5050
"//src/api/python/pxapi:pxapi_library",
5151
"//src/api/python/pxapi/proto:pxapi_py_proto_library",
52+
"@gogo_grpc_proto//github/gogo/protobuf/gogoproto:gogo_pl_py_proto",
5253
],
5354
)
5455

0 commit comments

Comments
 (0)