Skip to content

Commit 147d58d

Browse files
committed
Fix version detection for kernesl < 6 and fix arm64 builds
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent dde3f85 commit 147d58d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

tools/docker/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ endif
221221
KERN_MAJ=$$(echo $* | cut -d. -f1); \
222222
KERN_MIN=$$(echo $* | cut -d. -f2); \
223223
HEADERS_DOCKERFILE_SUFFIX=""; \
224-
if [ $${KERN_MAJ} -le 6 ] && [ $${KERN_MIN} -lt 3 ]; then \
224+
if [ $${KERN_MAJ} -lt 6 ] || { [ $${KERN_MAJ} -le 6 ] && [ $${KERN_MIN} -lt 3 ]; }; then \
225225
HEADERS_DOCKERFILE_SUFFIX=".bionic"; \
226226
fi; \
227227
linux_headers_image_tag="gcr.io/pixie-oss/pixie-dev-public:$*-$(LINUX_HEADERS_REV)"; \
@@ -241,14 +241,14 @@ endif
241241
KERN_MAJ=$$(echo $* | cut -d. -f1); \
242242
KERN_MIN=$$(echo $* | cut -d. -f2); \
243243
HEADERS_DOCKERFILE_SUFFIX=""; \
244-
if [ $${KERN_MAJ} -le 6 ] && [ $${KERN_MIN} -lt 3 ]; then \
244+
if [ $${KERN_MAJ} -lt 6 ] || { [ $${KERN_MAJ} -le 6 ] && [ $${KERN_MIN} -lt 3 ]; }; then \
245245
HEADERS_DOCKERFILE_SUFFIX=".bionic"; \
246246
fi; \
247247
linux_headers_image_tag="gcr.io/pixie-oss/pixie-dev-public:$*-$(LINUX_HEADERS_REV)"; \
248248
$(DOCKER) build --build-arg KERN_VERSION=$* \
249249
--build-arg ARCH=arm64 \
250250
--build-arg CROSS_COMPILE=aarch64-linux-gnu- \
251-
-f linux_headers_image/Dockerfile$(HEADERS_DOCKERFILE_SUFFIX) \
251+
-f linux_headers_image/Dockerfile$${HEADERS_DOCKERFILE_SUFFIX} \
252252
linux_headers_image -t "$${linux_headers_image_tag}" && \
253253
$(DOCKER) run --rm -v $(PWD)/$(LINUX_HEADER_ASSETS_BUILD_DIR):/output "$${linux_headers_image_tag}"
254254

0 commit comments

Comments
 (0)