Fix majority of oustanding linting issues after v2 migration

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Author: ddelnano

.golangci.yaml

@@ -17,19 +17,25 @@ linters:
     errcheck:
       exclude-functions:
       - io.Close
-      - github.com/spf13/pflag.MarkHidden
+      - (*github.com/spf13/pflag.FlagSet).MarkHidden
       - github.com/spf13/viper.BindEnv
       - github.com/spf13/viper.BindPFlag
-      - github.com/spf13/cobra.Help
-      - github.com/spf13/cobra.MarkFlagRequired
-      - github.com/spf13/cobra.Usage
+      - github.com/spf13/viper.BindPFlags
+      - (*github.com/spf13/cobra.Command).Help
+      - (*github.com/spf13/cobra.Command).MarkFlagRequired
+      - (*github.com/spf13/cobra.Command).Usage
       - (github.com/segmentio/analytics-go/v3.Client).Enqueue
-      - database/sql.Rollback
-      - github.com/nats-io/nats.go.Unsubscribe
+      - (*database/sql.Tx).Rollback
+      - (*github.com/nats-io/nats.go.Subscription).Unsubscribe
+    revive:
+      rules:
+      - name: unused-parameter
+        disabled: true
     staticcheck:
       checks:
       - all
       - "-ST1005"  # ignore the "ST1005: error strings should not be capitalized" check
+      - "-QF1008"  # ignore omit embedded fields from selector expression
   exclusions:
     generated: lax
     presets:

src/cloud/auth/controllers/login.go

@@ -385,7 +385,7 @@ func (s *Server) Signup(ctx context.Context, in *authpb.SignupRequest) (*authpb.
 	if !utils.IsNilUUIDProto(inviteOrgID) {
 		orgInfoPb, err := s.env.OrgClient().GetOrg(ctx, inviteOrgID)
 		if err != nil {
-			return nil, status.Errorf(codes.Internal, err.Error())
+			return nil, status.Error(codes.Internal, err.Error())
 		}
 		if orgInfoPb == nil {
 			return nil, status.Errorf(codes.InvalidArgument, "misformatted invite link")

src/cloud/shared/vzshard/vzshard.go

@@ -57,11 +57,11 @@ func ShardMax() string {
 
 // GenerateShardRange shard range produces the hex values 00-ff for the shards as configured.
 func GenerateShardRange() []string {
-	min := minShard()
-	max := maxShard()
-	r := make([]string, max-min+1)
-	for i := min; i <= max; i++ {
-		r[i-min] = shardIntToHex(i)
+	minS := minShard()
+	maxS := maxShard()
+	r := make([]string, maxS-minS+1)
+	for i := minS; i <= maxS; i++ {
+		r[i-minS] = shardIntToHex(i)
 	}
 	return r
 }

src/pixie_cli/pkg/utils/cli_out.go

@@ -121,7 +121,7 @@ func (c *CLIOutputEntry) Infof(format string, args ...interface{}) {
 
 // Info prints the input string to stdout.
 func (c *CLIOutputEntry) Info(str string) {
-	c.Infof(str)
+	c.Infof("%s", str)
 }
 
 // Errorf prints the input string to stderr formatted with the input args.
@@ -131,7 +131,7 @@ func (c *CLIOutputEntry) Errorf(format string, args ...interface{}) {
 
 // Error prints the input string to stderr.
 func (c *CLIOutputEntry) Error(str string) {
-	c.write(os.Stderr, str)
+	c.write(os.Stderr, "%s", str)
 }
 
 // Fatalf prints the input string to stderr formatted with the input args.
@@ -142,6 +142,6 @@ func (c *CLIOutputEntry) Fatalf(format string, args ...interface{}) {
 
 // Fatal prints the input string to stderr.
 func (c *CLIOutputEntry) Fatal(str string) {
-	c.write(os.Stderr, str)
+	c.write(os.Stderr, "%s", str)
 	os.Exit(1)
 }

src/pixie_cli/pkg/vizier/stream_adapter.go

@@ -254,7 +254,7 @@ func (v *StreamOutputAdapter) handleStream(ctx context.Context, stream chan *Exe
 			case *vizierpb.ExecuteScriptResponse_Data:
 				err = v.handleData(ctx, res)
 			default:
-				err = fmt.Errorf("unhandled response type" + reflect.TypeOf(msg.Resp.Result).String())
+				err = fmt.Errorf("unhandled response type %s", reflect.TypeOf(msg.Resp.Result).String())
 			}
 			if err != nil {
 				v.err = newScriptExecutionError(CodeBadData, "failed to handle data from Vizier: "+err.Error())

src/stirling/demo_apps/go_http/server/simple_http_server.go

@@ -68,13 +68,6 @@ func randStringRunes(n int) string {
 	return string(b)
 }
 
-func min(x, y int64) int64 {
-	if x < y {
-		return x
-	}
-	return y
-}
-
 func fakeLoad(w *http.ResponseWriter, latency float64, mIters, respSize int64) float64 {
 	// add some jitters
 	// latency = rand.NormFloat64()*latency/10 + latency

src/stirling/demo_apps/wrk_sweeper/wrk_sweeper.go

@@ -117,24 +117,24 @@ func parseSpec(spec string) SequenceGenerator {
 	linRegex := regexp.MustCompile(`lin\((\d+), \s*(\d+),\s*(\d+)\)`)
 	expMatches := expRegex.FindStringSubmatch(spec)
 	if len(expMatches) == 4 {
-		min := parseOrDie(expMatches[1])
-		max := parseOrDie(expMatches[2])
+		minSeq := parseOrDie(expMatches[1])
+		maxSeq := parseOrDie(expMatches[2])
 		base := parseOrDie(expMatches[3])
 		return &expSequenceGenerator{
-			Min:  min,
-			Max:  max,
+			Min:  minSeq,
+			Max:  maxSeq,
 			Base: base,
 		}
 	}
 
 	linMatches := linRegex.FindStringSubmatch(spec)
 	if len(linMatches) == 4 {
-		min := parseOrDie(linMatches[1])
-		max := parseOrDie(linMatches[2])
+		minSeq := parseOrDie(linMatches[1])
+		maxSeq := parseOrDie(linMatches[2])
 		step := parseOrDie(linMatches[3])
 		return &linSequenceGenerator{
-			Min:  min,
-			Max:  max,
+			Min:  minSeq,
+			Max:  maxSeq,
 			Step: step,
 		}
 	}

src/utils/erroraccumulator.go

@@ -45,7 +45,7 @@ func (ea *ErrorAccumulator) Merge() error {
 	if len(ea.errorStrs) == 0 {
 		return nil
 	}
-	return fmt.Errorf(indent(strings.Join(ea.errorStrs, "\n")))
+	return fmt.Errorf("%s", indent(strings.Join(ea.errorStrs, "\n")))
 }
 
 // MakeErrorAccumulator constructs the ErrorAccumulator.

src/utils/shared/k8s/apply.go

@@ -163,7 +163,7 @@ func GetResourcesFromYAML(yamlFile io.Reader) ([]*Resource, error) {
 
 		_, gvk, err := unstructured.UnstructuredJSONScheme.Decode(ext.Raw, nil, nil)
 		if err != nil {
-			log.WithError(err).Fatalf(err.Error())
+			log.WithError(err).Fatal(err.Error())
 			return nil, err
 		}
 

src/vizier/services/metadata/metadata_server.go

@@ -138,11 +138,11 @@ func cleanupOldPebbleData() {
 func mustInitPebbleDatastore() *pebbledb.DataStore {
 	cleanupOldPebbleData()
 	log.Infof("Using pebbledb: %s for metadata", pebbleOpenDir)
-	pebbleDb, err := pebble.Open(pebbleOpenDir, &pebble.Options{})
+	pebbleDB, err := pebble.Open(pebbleOpenDir, &pebble.Options{})
 	if err != nil {
 		log.WithError(err).Fatal("Failed to open pebble database. If out of space, increase the storage size of the `metadata-pv-claim` PersistentVolumeClaim and restart the vizier-metadata pod")
 	}
-	return pebbledb.New(pebbleDb, pebbledbTTLDuration)
+	return pebbledb.New(pebbleDB, pebbledbTTLDuration)
 }
 
 func etcdTLSConfig() (*tls.Config, error) {